Skip to content

Avoid using global state #26

Description

@ThiefMaster

Please consider using standard OOP patterns as it's common for such libraries instead of relying on global state.
Nothing wrong with providing some convenience utils that rely on a global client, but developers who want to nicely encapsulate things should not be required to deal with global state.

A nice API would be something like this:

cconvert = CloudConvertClient(api_key=..., sandbox=...)
cconvert.foo()

I think #13 and #24 are both about issues which are implicitly caused by the current design.

For a commercial product (albeit at very decent pricing, so nothing wrong with that!) I also find the lack of activity on this repo (and issues) a bit worrying TBH. Can we assume that your infrastructure is better maintained than the client libraries? I'd hope so but you never know... ;)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions