Fetch ancestors outside of loop

meshy · meshy · commit 27fbac294741 · 2024-06-13T20:50:20.000+01:00
diff --git a/cbv/views.py b/cbv/views.py
@@ -70,13 +70,14 @@ def get_context_data(self, **kwargs):
             klass.module.project_version, klass.module, klass
         )
         direct_ancestors = list(klass.get_ancestors())
+        all_ancestors = klass.get_all_ancestors()
         ancestors = [
             self.Ancestor(
                 name=ancestor.name,
                 url=ancestor.get_absolute_url(),
                 is_direct=ancestor in direct_ancestors,
             )
-            for ancestor in klass.get_all_ancestors()
+            for ancestor in all_ancestors
         ]
         children = [
             self.Child(

Original file line number	Diff line number	Diff line change
`@@ -70,13 +70,14 @@ def get_context_data(self, **kwargs):`
`70`	`70`	`klass.module.project_version, klass.module, klass`
`71`	`71`	`)`
`72`	`72`	`direct_ancestors = list(klass.get_ancestors())`
	`73`	`+ all_ancestors = klass.get_all_ancestors()`
`73`	`74`	`ancestors = [`
`74`	`75`	`self.Ancestor(`
`75`	`76`	`name=ancestor.name,`
`76`	`77`	`url=ancestor.get_absolute_url(),`
`77`	`78`	`is_direct=ancestor in direct_ancestors,`
`78`	`79`	`)`
`79`		`- for ancestor in klass.get_all_ancestors()`
	`80`	`+ for ancestor in all_ancestors`
`80`	`81`	`]`
`81`	`82`	`children = [`
`82`	`83`	`self.Child(`