Create vegetation-ecology-and-diversity.csl#8155
Conversation
|
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
|
😟 There are some issues with your submission. 2 tests failedThe CSL Style Repository may not contain any (non-excepted) duplicate ISSNs vegetation-ecology-and-diversity: "template" link must point to an existing independent style Please check the test report for details. |
|
😟 There are some issues with your submission. 1 test failedvegetation-ecology-and-diversity: "template" link must point to an existing independent style Please check the test report for details. |
|
Sorry, but this error message is a bit terse, and it seems just a matter of escaping characters. https://www.zotero.org/styles/pensoft-journals exists and is linked in the same form by other CSL of other journals. |
|
you made it into "https" |
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: vegetation-ecology-and-diversity.csl (new)(Anon 2012, Fenner … 2019) |
Well, that fixed it, thanks. Seems restrictive, since https is allowed for the documentation field, but I guess it doesn't matter, since most modern browsers should convert it to https. Let me fix the inline citations: "..." should be used in the references but not in the citations instead of "et al." |
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: vegetation-ecology-and-diversity.csl (new)(Anon 2012, Fenner et al. 2019) |
|
There. I ended up using the default behaviour of the "and others" term, which seems to correctly render as ellipses in all editors I have tried (Zotero, visual CSL editor, the bot here). It doesn't seem like the terms specification is flexible enough to define something custom more explicitly (to ensure that it always gets rendered as "...") so this will have to do. |
| <name>Luciano Ludovico Maria De Benedictis</name> | ||
| <email>luciano.debenedictis@unicam.it</email> | ||
| </author> | ||
| <contributor> |
There was a problem hiding this comment.
I assume these are remnants from the template style. Remove if so
There was a problem hiding this comment.
I am the author. I reported the authors of the template style as contributors. Is this correct?
There was a problem hiding this comment.
As I say, if they're from the template, remove them.
There was a problem hiding this comment.
ok, I will remove contributors and leave what's before, because those other things are updated. I appreciate your assistance, if you want to be listed as contributor or acknowledged in some other way let me know under which credentials.
| <if type="legal_case" match="none"> | ||
| <choose> | ||
| <if variable="DOI"> | ||
| <group delimiter=" "> |
There was a problem hiding this comment.
THis group does nothing. remove
There was a problem hiding this comment.
For this and the following: these are all present in the template Pensoft style, to which I made minimal edits, mostly to correctly use "..." for more than 6 authors in the bibliography. I will trust you and remove these lines if unnecessary, but then that should be done for the Pensoft style as well (which most journals of the publisher point to). I am not affiliated with the publisher so I won't correct that style myself, focusing only on this one.
There was a problem hiding this comment.
Right, but we'd want this fixed.
In the future somebody will use this style as a template and then we need to fix it in that one.
I also don't know how old that style is, but we've gotten a bit more stringent with style quality.
There was a problem hiding this comment.
Right, agreed. Maybe this could become the template for the updated version of that style! I will do what I can.
| </if> | ||
| <else-if variable="URL"> | ||
| <group delimiter=" " suffix="."> | ||
| <text variable="URL" prefix="Available from: "/> |
There was a problem hiding this comment.
Replace such hardcoded text elements with the appropriate term
There was a problem hiding this comment.
I'm not sure what to replace them with. Do you have any pointers? The CSL 1.0.2 Specification shows a similar hardcoded solution befor the URL, just within a group.
There was a problem hiding this comment.
No, it doesn't show that. It uses a term
There was a problem hiding this comment.
ok. The closest terms are either "available at" or "retrieved". Should I use either of those, possibly with the appropriate suffix, in another <text> before the URL line inside the group, even if it might result in a slightly different wording?
| </date> | ||
| <choose> | ||
| <if type="book" match="any"> | ||
| <text macro="legal_case"/> |
There was a problem hiding this comment.
I don't know any better than you do. Should I just remove this "legal_case" line?
| </group> | ||
| <group prefix=" " suffix="." delimiter=", "> | ||
| <text macro="publisher"/> | ||
| <text variable="number-of-pages" prefix=" " suffix=" pp"/> |
There was a problem hiding this comment.
replace the hardcoded text with the appropriate label. Check the rest of your style for such issues.
There was a problem hiding this comment.
I think in this case it should be something like <text variable="number-of-pages" prefix=" form="short"/> leaving the default plural="contextual". Not sure if prefix is necessary. I will do the same at line 228. Anything else of this sort?
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: vegetation-ecology-and-diversity.csl (new)(Anon 2012, Fenner et al. 2019) |
| <text variable="collection-title" suffix="."/> | ||
| <group suffix="."> | ||
| <text macro="publisher"/> | ||
| <group delimiter=" " prefix=", " suffix="."> |
There was a problem hiding this comment.
this group is single element, but has some additional variables. move them to the text block?
| <group prefix=" " suffix="."> | ||
| <text variable="container-title"/> | ||
| <group prefix=" "> | ||
| <text variable="volume"/> |
There was a problem hiding this comment.
move prefix inside <text> and remove group?

CSL Styles Pull Request Template
Description
I have made a CSL for the journal "Vegetation Ecology and Diversity".
Checklist
<info>block at the beginning of the file withrel="template".rel="documentation".<author>of the style or<contributor>for a style update.<text variable="page" prefix="pp. "/>).<text value="...if not absolutely necessary.