You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit ff6871c
Browse filesBrowse the repository at this point in the historyBrowse files
fix(self-test): start no job for a review requested on a closed pull request
The review workflow skips a request on a closed pull request with the reason
`closed`, so the verify job went red for a harmless event. The skipped and
review jobs now also require the pull request to be open for a review_requested
event, so none of them starts. The conditions' tests cover the closed case.
Also documents, in the README, that a request by a bot, the review agent or a
non-member fails the test by design (reasons bot, review-agent,
not-a-team-member), and that a pull request opened with the agent already in
Reviewers sends two events, where a third request replaces a waiting one and
its verify reports the request as not sent. A new test runs the skipped job's
DRAFT expression and script, which nothing exercised, and checks the reason
text for a draft, a fork and a bot.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012Jmn7nyyNodWTyouEMfLWr
Copy file name to clipboardExpand all lines: README.md
+6Lines changed: 6 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -291,6 +291,8 @@ The `verify` job fails with one error that says what went wrong:
291
291
-`No reply from the stub routine within 300 seconds`: the request was sent, but no comment by `@cipherstash-agent` on the pull request names this run attempt. The error says how many comments the last read took and how many comments with the marker and this attempt's link were ignored for being from another author. Each such comment also gets a notice, `Reply ignored`, that names its author and association. If there are some, the stub posted as a different account than `REPLY_AUTHOR`. Otherwise check that the stub's prompt matches the one above, that the stub can comment on this repository, and the stub's session in Claude. If reading the comments failed as well, the error ends with the last failure.
292
292
-`REPLY_AUTHOR is empty or missing`: the workflow does not name the account whose reply to accept, so the job fails at once rather than accept anyone's comment.
293
293
294
+
A requested-reviewer request made by a bot, by the review agent itself, or by someone who is not on the team also makes the test fail, by design: the review workflow skips it with the reason `bot`, `review-agent` or `not-a-team-member`, and the `verify` job reports that reason. Such a request tests nothing about the stub. A review requested on a closed pull request starts no self-test job at all.
295
+
294
296
Each attempt looks only for a reply that names its own attempt's link, so a reply to an earlier run or an earlier attempt never counts.
295
297
296
298
### Running the test again
@@ -307,6 +309,10 @@ For those, mark the pull request as a draft and then as ready for review.
307
309
A requested-reviewer request needs the membership check, because the person who requested the review must be a team member.
308
310
If the App's secrets do not reach this repository, it fails with the reason `membership-lookup-failed` (see [Settings](#settings)).
309
311
312
+
A pull request that is opened with `cipherstash-agent` already in Reviewers sends two events, `opened` and `review_requested`, so it starts two self-test runs.
313
+
Only one request is sent at a time for a pull request, so the second waits. A third request that arrives while the second is waiting replaces the waiting one (see `concurrency` above).
314
+
The replaced run's `verify` job then reports that the request was not sent, because its `fire` job was cancelled. That failure is expected, and the newer run tests the commit.
315
+
310
316
"Re-run all jobs" tests the same commit again, and gets a new attempt, with a new attempt link.
0 commit comments