Skip to content

Commit dd228c9

Browse files
committed
Merge branch 'feat/self-test-ready' into feat/self-test-rerun
Brings in the self-repository form and its actionlint ignore. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Jmn7nyyNodWTyouEMfLWr # Conflicts: # .github/workflows/self-test.yml # README.md
2 parents fa9ce10 + c83a4e1 commit dd228c9

4 files changed

Lines changed: 17 additions & 8 deletions

File tree

‎.github/actionlint.yaml‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,18 @@
55
# "property ... is not defined in object type". The shared review workflow uses them to
66
# check out this repository at the commit the caller pinned (see #20, #21 and #22).
77
#
8-
# Only those two messages are ignored, and only in claude-review.yml. Every other check
9-
# still runs on every file. Remove this file once an actionlint release knows the
10-
# job.workflow_* properties, and bump the pin in checks.yml.
8+
# GitHub also added the self-repository form, `uses: $/path`, on 30 July 2026. It names
9+
# this repository at the exact commit that is running. zizmor asks for it in place of
10+
# `./path`, but actionlint v1.7.12 reports it as a badly formed reusable workflow call.
11+
# The self-test calls the review workflow that way (see #29).
12+
#
13+
# Only these messages are ignored, each only in the file named. Every other check still
14+
# runs on every file. Remove an entry once an actionlint release knows the syntax, and
15+
# bump the pin in checks.yml.
1116
paths:
1217
.github/workflows/claude-review.yml:
1318
ignore:
1419
- 'property "workflow_(repository|sha)" is not defined in object type'
20+
.github/workflows/self-test.yml:
21+
ignore:
22+
- 'reusable workflow call "\$/[^"]*" at "uses" is not following the format'

‎.github/workflows/self-test.yml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
#
55
# When a pull request here is opened, reopened or marked ready for review, or a review is requested (or re-requested)
66
# from the review agent, cipherstash-agent, the review job calls this pull request's own version of
7-
# .github/workflows/claude-review.yml (a local path, not a pinned commit), with the stub's trigger id and token. The
7+
# .github/workflows/claude-review.yml (`$/`, GitHub's form for this repository at the exact
8+
# commit that is running, not a pinned commit), with the stub's trigger id and token. The
89
# verify job then fails if the review workflow decided not to request a review, naming the skip reason, if the request
910
# was of the wrong kind for the event, or if it was not sent, and otherwise waits a few minutes for the stub's reply
1011
# naming this run attempt.
@@ -76,7 +77,7 @@ jobs:
7677
# even one that will not run. Only its react job uses it, for a comment command, which this test does not make.
7778
permissions:
7879
issues: write
79-
uses: ./.github/workflows/claude-review.yml
80+
uses: $/.github/workflows/claude-review.yml
8081
with:
8182
routine-trigger-id: ${{ vars.CLAUDE_ROUTINE_INTEGRATION_TEST_TRIGGER_ID }}
8283
secrets:

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ The stub only posts a comment saying it received the request, so a test run is f
245245

246246
[`.github/workflows/self-test.yml`](.github/workflows/self-test.yml) runs when a pull request in this repository is opened, reopened or marked ready for review, and when someone requests a review from the review agent, `cipherstash-agent`, on a pull request here.
247247

248-
1. The `review` job calls the pull request's own version of `.github/workflows/claude-review.yml`, by its local path, so the version under test is the one in the pull request. It passes the stub routine's trigger id and token, never the real routine's.
248+
1. The `review` job calls the pull request's own version of `.github/workflows/claude-review.yml`, by GitHub's self-repository form, `uses: $/.github/workflows/claude-review.yml`, so the version under test is the one in the pull request, at the exact commit that is running. (`$/` needs github.com and runner 2.336.0 or later.) It passes the stub routine's trigger id and token, never the real routine's.
249249
2. The review workflow decides, as it would for any repository. For a review requested from `cipherstash-agent`, the person who requested it must be a member of the `@cipherstash/developers` team, as for any requested reviewer. If it decides to request a review, it sends the request to the stub. The request text includes a link to this run attempt, `<server>/<repo>/actions/runs/<id>/attempts/<n>`.
250250
3. The stub posts a comment on the pull request, echoing the attempt's link.
251251
4. The `verify` job checks the review workflow's decision. The request must be a Ready request when the pull request was opened, reopened or marked ready, and a requested-reviewer request when a review was requested. If it decided to request a review of the right kind and sent the request, the job reads the pull request's comments every 15 seconds, for up to 5 minutes, until it finds a comment that contains `integration-test: received` and this attempt's link. Only a comment posted by the stub routine's account, `cipherstash-agent` (the `REPLY_AUTHOR` setting in the workflow; the login is compared without regard to case), counts, so someone else cannot pass the test by posting the marker on a public pull request. The comment author's standing in the repository (`author_association`) is not used, because the job's token may see a different standing for an account with private organisation membership. It then shows the reply, and its author, in a notice and in the run's summary.

‎tests/test_self_test.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,8 @@ def test_it_runs_on_the_ready_and_requested_reviewer_events(self):
175175
)
176176

177177
def test_it_calls_this_pull_requests_own_review_workflow(self):
178-
# A local path, so the version under test is the pull request's, not a pinned commit.
179-
self.assertEqual(value(".jobs.review.uses"), "./.github/workflows/claude-review.yml")
178+
# GitHub's self-repository form: this repository, at the exact commit that is running, not a pinned commit.
179+
self.assertEqual(value(".jobs.review.uses"), "$/.github/workflows/claude-review.yml")
180180

181181
def test_it_uses_the_stub_routines_trigger_and_token(self):
182182
self.assertEqual(

0 commit comments

Comments
 (0)