You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 6a9bc32
Browse filesBrowse the repository at this point in the historyBrowse files
Copy file name to clipboardExpand all lines: README.md
+3-2Lines changed: 3 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -248,7 +248,7 @@ The stub only posts a comment saying it received the request, so a test run is f
248
248
1. The `review` job calls the pull request's own version of `.github/workflows/claude-review.yml`, by its local path, so the version under test is the one in the pull request. It passes the stub routine's trigger id and token, never the real routine's.
249
249
2. The review workflow decides, as it would for any repository. For a review requested from `cipherstash-agent`, the person who requested it must be a member of the `@cipherstash/developers` team, as for any requested reviewer. If it decides to request a review, it sends the request to the stub. The request text includes a link to this run attempt, `<server>/<repo>/actions/runs/<id>/attempts/<n>`.
250
250
3. The stub posts a comment on the pull request, echoing the attempt's link.
251
-
4. The `verify` job checks the review workflow's decision. The request must be a Ready request when the pull request was opened, reopened or marked ready, and a requested-reviewer request when a review was requested. If it decided to request a review of the right kind and sent the request, the job reads the pull request's comments every 15 seconds, for up to 5 minutes, until it finds a comment that contains `integration-test: received` and this attempt's link. Only a comment whose `author_association` is `OWNER`, `MEMBER` or `COLLABORATOR`counts, so someone else cannot pass the test by posting the marker on a public pull request. It then shows the reply, and its author, in a notice and in the run's summary.
251
+
4. The `verify` job checks the review workflow's decision. The request must be a Ready request when the pull request was opened, reopened or marked ready, and a requested-reviewer request when a review was requested. If it decided to request a review of the right kind and sent the request, the job reads the pull request's comments every 15 seconds, for up to 5 minutes, until it finds a comment that contains `integration-test: received` and this attempt's link. Only a comment posted by the stub routine's account, `cipherstash-agent` (the `REPLY_AUTHOR` setting in the workflow; the login is compared without regard to case), counts, so someone else cannot pass the test by posting the marker on a public pull request. The comment author's standing in the repository (`author_association`) is not used, because the job's token may see a different standing for an account with private organisation membership. It then shows the reply, and its author, in a notice and in the run's summary.
252
252
253
253
The test is skipped, and the `skipped` job says why in a notice, for:
254
254
@@ -289,7 +289,8 @@ The `verify` job fails with one error that says what went wrong:
289
289
-`The review workflow gave no decision to request a review`: the review workflow did not finish its decision. Look at its `decide` job.
290
290
-`... but the request was not sent to the stub routine`: the stub's trigger refused the request or could not be reached. The `review / fire` job's error says why. Check the token secret and the trigger id variable. If the `fire` job was cancelled, a newer request (a newer push or event for the same pull request) may have replaced it.
291
291
-`GitHub answered HTTP 401, 403 or 404 when asked for the pull request's comments`: retrying cannot fix it, so the job fails at once. Check the job's token and permissions.
292
-
-`No reply from the stub routine within 300 seconds`: the request was sent, but no comment on the pull request names this run attempt. Check that the stub's prompt matches the one above, that the stub can comment on this repository, and the stub's session in Claude. If reading the comments failed as well, the error ends with the last failure.
292
+
-`No reply from the stub routine within 300 seconds`: the request was sent, but no comment by `@cipherstash-agent` on the pull request names this run attempt. The error says how many comments the last read took and how many comments with the marker and this attempt's link were ignored for being from another author. Each such comment also gets a notice, `Reply ignored`, that names its author and association. If there are some, the stub posted as a different account than `REPLY_AUTHOR`. Otherwise check that the stub's prompt matches the one above, that the stub can comment on this repository, and the stub's session in Claude. If reading the comments failed as well, the error ends with the last failure.
293
+
-`REPLY_AUTHOR is empty or missing`: the workflow does not name the account whose reply to accept, so the job fails at once rather than accept anyone's comment.
293
294
294
295
Each attempt looks only for a reply that names its own attempt's link, so a reply to an earlier run or an earlier attempt never counts.
0 commit comments