Skip to content

Commit 63da8b3

Browse files
committed
fix(eql): drop private tracker ids from comments
test:public_identifiers forbids private issue identifiers in tracked files; describe the behaviour directly instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Jmn7p5byuYMWqoxDUAZQE
1 parent 169f985 commit 63da8b3

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎packages/eql/crates/eql-codegen/src/context.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ pub fn wrapper_entry(dom: &str, op: &Operator, arg_a: &str, arg_b: &str, term: T
291291
/// unpinned `LANGUAGE sql` so it can inline, which means its body is parsed
292292
/// under the caller's `search_path` — a bare operator would resolve to whatever
293293
/// that path finds. See [`Term::operator_schema`] for the ORE failure this
294-
/// closes (CIP-5153). Qualifying keeps the wrapper inlinable: the inlined
294+
/// closes. Qualifying keeps the wrapper inlinable: the inlined
295295
/// expression carries the same operator OID either way.
296296
pub fn qualified_body_operator(op: &Operator, term: Term) -> String {
297297
format!(

‎packages/eql/crates/eql-codegen/src/generate.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,7 +1153,7 @@ mod tests {
11531153
/// is parsed under the CALLER's `search_path`; a bare operator resolves to
11541154
/// whatever that path finds. For the ORE term, whose operators live in
11551155
/// `public`, a caller without `public` on the path got pg_catalog's RECORD
1156-
/// comparison — byte-wise ciphertext order, no error (CIP-5153). A bare
1156+
/// comparison — byte-wise ciphertext order, no error. A bare
11571157
/// operator token anywhere in a wrapper body fails here.
11581158
#[test]
11591159
fn every_wrapper_body_schema_qualifies_its_operators() {
@@ -1179,7 +1179,7 @@ mod tests {
11791179
// wrong mapping there fails this test for every family. The
11801180
// ORE term compares a composite type whose operators are in
11811181
// `public`; naming pg_catalog there reaches the built-in
1182-
// RECORD comparison, the CIP-5153 byte-order bug.
1182+
// RECORD comparison, the byte-order bug this guards.
11831183
let want = if line.contains("eql_v3.ord_term_ore(") {
11841184
" OPERATOR(public."
11851185
} else {

‎packages/eql/crates/eql-domains/src/term.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ impl Term {
112112
/// `eql_v3_internal.ore_block_256` is a composite type whose comparison
113113
/// operators live in `public`, and with `public` off the path a bare `<`
114114
/// resolves to pg_catalog's built-in RECORD comparison, ordering the
115-
/// ciphertext bytes lexicographically with no error (CIP-5153). Naming the
115+
/// ciphertext bytes lexicographically with no error. Naming the
116116
/// schema makes resolution independent of the caller's path.
117117
///
118118
/// The other terms are domains over built-in types (`text`, `smallint[]`,

‎packages/eql/tests/sqlx/tests/v3_search_path_independence_tests.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//! The `eql_v3` comparison wrappers give the same answer whatever the caller's
2-
//! `search_path` is (CIP-5153).
2+
//! `search_path` is.
33
//!
44
//! The wrappers (`eql_v3.lt`, `eql_v3.eq`, …) are unpinned `LANGUAGE sql`
55
//! functions — pinning a `search_path` would stop them inlining, and with it

0 commit comments

Comments
 (0)