While correcting FreeCAD-pyOpTools to work with the new part catalogs in JSON, I found that some cylindrical lenses have the Width and Length inverted. For example, the cylindrical lens LJ1014L1, that according to the Thorlabs catalog has a size of H = 16.00 mm, L = 18.0 mm, but when importing the lens it gives:
L=library.Thorlabs["LJ1014L1"]
print("Size=",L.size)
Size= [9, 8]
that means H=18 and L=16 mm, which is wrong.
Testing the same code with another reference (LJ1125L2) that according to the Thorlabs catalog has a size of H = 20.00 mm, L = 40.0 mm, gives
L=library.Thorlabs["LJ1125L2"]
print("Size=",L.size)
Size= [10, 20]
That is the correct answer (H=20, L=40).
It seems that some lenses are just wrong in the thorlabs catalog, and this could be corrected in the pyoptools catalog. But how do we avoid to introduce wrong data again in the catalog, if the lens data is re imported from the Thorlabs catalog file?
@rdgraham what do you think?
While correcting FreeCAD-pyOpTools to work with the new part catalogs in JSON, I found that some cylindrical lenses have the Width and Length inverted. For example, the cylindrical lens LJ1014L1, that according to the Thorlabs catalog has a size of H = 16.00 mm, L = 18.0 mm, but when importing the lens it gives:
that means H=18 and L=16 mm, which is wrong.
Testing the same code with another reference (LJ1125L2) that according to the Thorlabs catalog has a size of H = 20.00 mm, L = 40.0 mm, gives
That is the correct answer (H=20, L=40).
It seems that some lenses are just wrong in the thorlabs catalog, and this could be corrected in the pyoptools catalog. But how do we avoid to introduce wrong data again in the catalog, if the lens data is re imported from the Thorlabs catalog file?
@rdgraham what do you think?