From 11a27630eccfe27f3f6324df045bb09b1e0b271e Mon Sep 17 00:00:00 2001 From: Proletariat Agent Date: Wed, 6 May 2026 14:34:19 -0600 Subject: [PATCH] feat(PRLT-1370): fix(PRLT-1370): isClaudeExecutor accepts legacy 'claude' value so credential mount applies --- apps/cli/src/lib/execution/runners/executor.ts | 6 +++++- apps/cli/test/unit/execution-utils.test.ts | 6 ++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/apps/cli/src/lib/execution/runners/executor.ts b/apps/cli/src/lib/execution/runners/executor.ts index 9978cf356..d22f068e5 100644 --- a/apps/cli/src/lib/execution/runners/executor.ts +++ b/apps/cli/src/lib/execution/runners/executor.ts @@ -38,9 +38,13 @@ export function getExecutorCommand(executor: ExecutorType, prompt: string, skipP /** * Check if an executor is Claude Code. + * + * Accepts both 'claude-code' (current canonical value) and 'claude' (legacy + * value seeded by migration 0023 into workspace_settings.execution.default_executor). + * Without this, the credential bind mount is skipped for workspaces seeded with 'claude'. */ export function isClaudeExecutor(executor: ExecutorType): boolean { - return executor === 'claude-code' + return executor === 'claude-code' || (executor as string) === 'claude' } /** diff --git a/apps/cli/test/unit/execution-utils.test.ts b/apps/cli/test/unit/execution-utils.test.ts index b290a8fa0..d39eb8f4b 100644 --- a/apps/cli/test/unit/execution-utils.test.ts +++ b/apps/cli/test/unit/execution-utils.test.ts @@ -367,6 +367,12 @@ describe('Execution Utils', () => { expect(isClaudeExecutor('claude-code')).to.be.true }) + it('should return true for legacy claude value (PRLT-1370)', () => { + // Migration 0023 seeds workspace_settings with 'claude', so the credential + // mount must still be applied when the DB returns this legacy value. + expect(isClaudeExecutor('claude' as ExecutorType)).to.be.true + }) + it('should return false for codex', () => { expect(isClaudeExecutor('codex')).to.be.false })