Add updated_at and sort so oldest is picked first

Author: zarya

src/teams/migrations/0069_teamshiftassignment_updated_at.py

@@ -0,0 +1,18 @@
+# Generated by Django 4.2.21 on 2025-06-22 17:38
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('teams', '0068_alter_teamshift_team_members'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='teamshiftassignment',
+            name='updated_at',
+            field=models.DateTimeField(auto_now=True),
+        ),
+    ]

src/teams/models.py

@@ -573,6 +573,8 @@ class TeamShiftAssignment(CampRelatedModel):
         help_text="Is the shift assignment for sale?",
     )
 
+    updated_at = models.DateTimeField(auto_now=True)
+
     @property
     def camp(self) -> Camp:
         """All CampRelatedModels must have a camp FK or a camp property."""

src/teams/views/shifts.py

@@ -324,10 +324,7 @@ def get_context_data(self, **kwargs) -> dict[str, object]:
         """Method for setting the page context data."""
         context = super().get_context_data(**kwargs)
         context['action'] = f"Are you sure you want to take this {self.object}?"
-        context["team"] = Team.objects.get(
-            camp=self.camp,
-            slug=self.kwargs["team_slug"],
-        )
+        context["team"] = self.object.team 
         return context
 
     def form_valid(self, form: ModelForm[TeamShift]) -> HttpResponseRedirect:
@@ -359,7 +356,7 @@ def form_valid(self, form: ModelForm[TeamShift]) -> HttpResponseRedirect:
         else:
             # Remove at most one shift assignment for sale if any
             # When a shift is for sale and a user presses assign its first assigning the for sale one
-            for shift_assignment in shift.team_members.filter(teamshiftassignment__for_sale=True)[:1]:
+            for shift_assignment in shift.team_members.filter(teamshiftassignment__for_sale=True).order_by('teamshiftassignment__updated_at')[:1]:
                 shift.team_members.remove(shift_assignment)
             shift.team_members.add(team_member)
 
@@ -380,10 +377,7 @@ def get_context_data(self, **kwargs) -> dict[str, object]:
         """Method for setting the page context data."""
         context = super().get_context_data(**kwargs)
         context['action'] = f"Are you sure you want to drop this {self.object}?"
-        context["team"] = Team.objects.get(
-            camp=self.camp,
-            slug=self.kwargs["team_slug"],
-        )
+        context["team"] = self.object.team 
         return context
 
     def form_valid(self, form: ModelForm[TeamShift]) -> HttpResponseRedirect:
@@ -412,10 +406,7 @@ def get_context_data(self, **kwargs) -> dict[str, object]:
         """Method for setting the page context data."""
         context = super().get_context_data(**kwargs)
         context['action'] = f"Are you sure you want to this {self.object} available to others?"
-        context["team"] = Team.objects.get(
-            camp=self.camp,
-            slug=self.kwargs["team_slug"],
-        )
+        context["team"] = self.object.team 
         return context
 
     http_methods = ("get",)