Description:
Currently, oscars depends on the boa_string crate via a git dependency to provide optional Trace and Finalize implementations for boa_string types:
# oscars/Cargo.toml
boa_string = { git = "https://github.com/boa-dev/boa.git", branch = "main", optional = true }
While this works for our experimental integration, it poses a blocker for publishing oscars to crates.io in the future. Crates published to crates.io cannot depend on unreleased git repositories.
Furthermore, having oscars depend downstream on boa's internal crates creates tight coupling and architectural inversion. To resolve this correctly for a release, we need to evaluate the following long-term solutions:
-
Move oscars into the boa workspace:
Bring the oscars garbage collector directly into the boa-dev/boa monorepo. This eliminates external versioning conflicts and allows internal crates to depend on each other seamlessly.
-
Move trait implementations into boa_string:
Instead of oscars depending on boa_string to implement Trace/Finalize for it, boa_string should depend on the oscars crate (or an oscars-core crate that provides the traits) and implement the GC traits locally.
Related PR: (#96 (comment))
Description:
Currently,
oscarsdepends on theboa_stringcrate via a git dependency to provide optionalTraceandFinalizeimplementations forboa_stringtypes:While this works for our experimental integration, it poses a blocker for publishing
oscarstocrates.ioin the future. Crates published tocrates.iocannot depend on unreleasedgitrepositories.Furthermore, having
oscarsdepend downstream onboa's internal crates creates tight coupling and architectural inversion. To resolve this correctly for a release, we need to evaluate the following long-term solutions:Move
oscarsinto theboaworkspace:Bring the
oscarsgarbage collector directly into theboa-dev/boamonorepo. This eliminates external versioning conflicts and allows internal crates to depend on each other seamlessly.Move trait implementations into
boa_string:Instead of
oscarsdepending onboa_stringto implementTrace/Finalizefor it,boa_stringshould depend on theoscarscrate (or anoscars-corecrate that provides the traits) and implement the GC traits locally.Related PR: (#96 (comment))