Skip to content

[maven][resolve] Provide a better logging experience for maven users when resolving#7255

Merged
chrisrueger merged 1 commit into
bndtools:masterfrom
timothyjward:fix/7217-resolve-log
Jun 5, 2026
Merged

[maven][resolve] Provide a better logging experience for maven users when resolving#7255
chrisrueger merged 1 commit into
bndtools:masterfrom
timothyjward:fix/7217-resolve-log

Conversation

@timothyjward

Copy link
Copy Markdown
Contributor

This commit updates the bndrun resolve process to be better able to log externally. The main driver for this is from maven plugins which currently get little to no logging from the resolve process. These now use an SLF4J logger to log resolve messages, while still logging to a temporary file to maintain the existing error reporting behaviour.

Fixes #7217

@timothyjward timothyjward requested a review from chrisrueger June 3, 2026 10:24
@chrisrueger

Copy link
Copy Markdown
Contributor

@timothyjward Thanks. Have you noticed the error in the run?

Error:  COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/bnd/bnd/maven-plugins/bnd-resolver-maven-plugin/src/main/java/aQute/bnd/maven/resolver/plugin/ResolverMojo.java:[22,25] biz.aQute.resolve.Slf4jResolverLogger is not public in biz.aQute.resolve; cannot be accessed from outside package
Error:  /home/runner/work/bnd/bnd/maven-plugins/bnd-resolver-maven-plugin/src/main/java/aQute/bnd/maven/resolver/plugin/VerifierMojo.java:[30,25] biz.aQute.resolve.Slf4jResolverLogger is not public in biz.aQute.resolve; cannot be accessed from outside package

Also I would like to ask @kwin for a review.

@timothyjward timothyjward force-pushed the fix/7217-resolve-log branch 2 times, most recently from 5768fec to c702b39 Compare June 3, 2026 13:14
…when resolving

This commit updates the bndrun resolve process to be better able to log externally. The main driver for this is from maven plugins which currently get little to no logging from the resolve process. These now use an SLF4J logger to log resolve messages, while still logging to a temporary file to maintain the existing error reporting behaviour.

Fixes bndtools#7217

Signed-off-by: Tim Ward <timothyjward@apache.org>
@timothyjward timothyjward force-pushed the fix/7217-resolve-log branch from c702b39 to 11b8fb9 Compare June 3, 2026 13:25

@chrisrueger chrisrueger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation-wise it looks fine for me. It is backwards compatible and I don't see obvious problems.
Haven't tested it though.

@kwin

kwin commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Thanks, LGTM.

@chrisrueger chrisrueger merged commit 0c8956e into bndtools:master Jun 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bnd-resolver-maven-plugin: Redirect resolver log to Maven plugin log

3 participants