You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The beyonic gem has about 38 failing specs caused by wrong data types. The errors are:
NoMethodError: undefined method 'each_pair' for #<Array:0x00007ff3606d7440> Did you mean? each_slice
NoMethodError: undefined method 'each' for "{'id': '1234', 'name': 'Lucy'}":String
Reproduction steps are simple:
cd into beyonic gem and run rspec spec
Using git blame I've been able to narrow down the problem to these specific lines introduced by @KayLuke.
Reverting the code back to the implementation by @ogerman fixes the first errors and adjusting the value of the metadata property on another spec fixes the later.
I have a branch with fixes for these test failures, happy to send in a PR to resolve this issue.
The beyonic gem has about 38 failing specs caused by wrong data types. The errors are:
NoMethodError: undefined method 'each_pair' for #<Array:0x00007ff3606d7440> Did you mean? each_sliceNoMethodError: undefined method 'each' for "{'id': '1234', 'name': 'Lucy'}":StringReproduction steps are simple:
rspec specUsing
git blameI've been able to narrow down the problem to these specific lines introduced by @KayLuke.Reverting the code back to the implementation by @ogerman fixes the first errors and adjusting the value of the metadata property on another spec fixes the later.
I have a branch with fixes for these test failures, happy to send in a PR to resolve this issue.