KeyboardInterrupt starts expensive background process

[ulfaslak]

This is a weird one. When I KeyboardInterrupt in a Jupyter Notebook, a very CPU hungry Python process starts.

When I restart the kernel, it terminates. If I terminate it in the activity monitor, the Jupyter kernel becomes busy (no output in terminal).

Even weirder, if I launch a new visualization, IT STOPS.

[benmaier]

possibly fixed (forgot thread.join()). Can you try?

[benmaier]

hey @ulfaslak did you have time to test it?

[ulfaslak]

Sorry, baby fog, will try later!

[benmaier]

sure, no rush! baby's more important :)

…

On Nov 19, 2018, at 13:40, Ulf Aslak ***@***.***> wrote: Sorry, baby fog, will try later! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKOzvP5_zi5acIHqo8XSGS1bjO_FhrVvks5uwqargaJpZM4YZq9D>.

[ulfaslak]

Alright, it was fast enough to try. So I upgraded with pip to v0.0.6 (right one?), but the bug is still there.

[benmaier]

Haven't updated in pip yet, you'd have to install from a cloned repo ..

…

On Nov 19, 2018, at 13:43, Ulf Aslak ***@***.***> wrote: Alright, it was fast enough to try. So I upgraded with pip to v0.0.6 (right one?), but the bug is still there. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKOzvHoDsYKiQpXnOPjrzouCc05a_zq_ks5uwqdWgaJpZM4YZq9D>.

[ulfaslak]

ah on sec

[ulfaslak]

ok i'm not being very thorough checking if I installed it right here, but downloading the repo and running python setup.py install it installs v 0.0.7, which also imports successfully, but throws the error DistutilsFileError: cannot copy tree '/anaconda3/lib/python3.7/site-packages/netwulf-0.0.7-py3.7.egg/netwulf/js': not a directory at visualize(G)

[benmaier]

cloning probably did not include the submodule then. Can you try git clone --recurse-submodules git@git....

…

On Nov 19, 2018, at 13:50, Ulf Aslak ***@***.***> wrote: ok i'm not being very thorough checking if I installed it right here, but downloading the repo and running python setup.py install it installs v 0.0.7, which also imports successfully, but throws the error DistutilsFileError: cannot copy tree '/anaconda3/lib/python3.7/site-packages/netwulf-0.0.7-py3.7.egg/netwulf/js': not a directory at visualize(G) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKOzvPH9htkQ5g9OuITlX4fihVyELGjvks5uwqkbgaJpZM4YZq9D>.

[ulfaslak]

Different behavior now. I interrupt and it doesn't stop, I interrupt it again and it throws error.

[benmaier]

ok, off to the to-do pile then. thanks for checking!

…

On Nov 19, 2018, at 14:00, Ulf Aslak ***@***.***> wrote: Different behavior now. I interrupt and it doesn't stop, I interrupt it again and it throws error. <https://user-images.githubusercontent.com/6390218/48708582-461a8400-ec03-11e8-8a23-9740e34c0f4b.gif> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKOzvEnFp5qusrS7Hb_PU7X5wtmB_b0qks5uwqt7gaJpZM4YZq9D>.

[benmaier]

is this fixed by now? 🤔

[benmaier]

can't reproduce