Describe the task
Remove biome-ignore lint/correctness/useExhaustiveDependencies comments and properly fix dep arrays in the HFI Calculator page and station admin modal.
Acceptance Criteria
Additional context
- CAUTION: a previous attempt here introduced an API flood loop and a lost loading indicator when switching fire centres. The mount effect and the
fireCentres/selectedFireCentre interaction are particularly sensitive.
- Use
useRef to read current values without subscribing if needed to break dep cycles.
Describe the task
Remove
biome-ignore lint/correctness/useExhaustiveDependenciescomments and properly fix dep arrays in the HFI Calculator page and station admin modal.Acceptance Criteria
apps/wps-web/src/features/hfiCalculator/pages/HfiCalculatorPage.tsx(7 effects: mount fetch, updatedPlanningAreaId ×2, selectedFireCentre, dateRange, fireCentres, stationsUpdateLoading)apps/wps-web/src/features/hfiCalculator/components/stationAdmin/ManageStationsModal.tsx(line 85)yarn biome lintpasses with zerouseExhaustiveDependencieserrors on both filesAdditional context
fireCentres/selectedFireCentreinteraction are particularly sensitive.useRefto read current values without subscribing if needed to break dep cycles.