format code

Signed-off-by: phernandez <paul@basicmachines.co>

Author: phernandez

src/basic_memory/mcp/tools/__init__.py

@@ -24,6 +24,7 @@
     create_memory_project,
     delete_project,
 )
+
 # ChatGPT-compatible tools
 from basic_memory.mcp.tools.chatgpt_tools import search, fetch
 

src/basic_memory/mcp/tools/chatgpt_tools.py

@@ -27,7 +27,7 @@ def _format_search_results_for_chatgpt(results: SearchResponse) -> List[Dict[str
         formatted_result = {
             "id": result.permalink or f"doc-{len(formatted_results)}",
             "title": result.title if result.title and result.title.strip() else "Untitled",
-            "url": result.permalink or ""
+            "url": result.permalink or "",
         }
         formatted_results.append(formatted_result)
 
@@ -43,11 +43,11 @@ def _format_document_for_chatgpt(
     """
     # Extract title from markdown content if not provided
     if not title and isinstance(content, str):
-        lines = content.split('\n')
-        if lines and lines[0].startswith('# '):
+        lines = content.split("\n")
+        if lines and lines[0].startswith("# "):
             title = lines[0][2:].strip()
         else:
-            title = identifier.split('/')[-1].replace('-', ' ').title()
+            title = identifier.split("/")[-1].replace("-", " ").title()
 
     # Ensure title is never None
     if not title:
@@ -60,21 +60,19 @@ def _format_document_for_chatgpt(
             "title": title or "Document Not Found",
             "text": content,
             "url": identifier,
-            "metadata": {"error": "Document not found"}
+            "metadata": {"error": "Document not found"},
         }
 
     return {
         "id": identifier,
         "title": title or "Untitled Document",
         "text": content,
         "url": identifier,
-        "metadata": {"format": "markdown"}
+        "metadata": {"format": "markdown"},
     }
 
 
-@mcp.tool(
-    description="Search for content across the knowledge base"
-)
+@mcp.tool(description="Search for content across the knowledge base")
 async def search(
     query: str,
     context: Context | None = None,
@@ -99,7 +97,7 @@ async def search(
             page=1,
             page_size=10,  # Reasonable default for ChatGPT consumption
             search_type="text",  # Default to full-text search
-            context=context
+            context=context,
         )
 
         # Handle string error responses from search_notes
@@ -108,44 +106,32 @@ async def search(
             search_results = {
                 "results": [],
                 "error": "Search failed",
-                "error_details": results[:500]  # Truncate long error messages
+                "error_details": results[:500],  # Truncate long error messages
             }
         else:
             # Format successful results for ChatGPT
             formatted_results = _format_search_results_for_chatgpt(results)
             search_results = {
                 "results": formatted_results,
                 "total_count": len(results.results),  # Use actual count from results
-                "query": query
+                "query": query,
             }
             logger.info(f"Search completed: {len(formatted_results)} results returned")
 
         # Return in MCP content array format as required by OpenAI
-        return [
-            {
-                "type": "text",
-                "text": json.dumps(search_results, ensure_ascii=False)
-            }
-        ]
+        return [{"type": "text", "text": json.dumps(search_results, ensure_ascii=False)}]
 
     except Exception as e:
         logger.error(f"ChatGPT search failed for query '{query}': {e}")
         error_results = {
             "results": [],
             "error": "Internal search error",
-            "error_message": str(e)[:200]
+            "error_message": str(e)[:200],
         }
-        return [
-            {
-                "type": "text",
-                "text": json.dumps(error_results, ensure_ascii=False)
-            }
-        ]
+        return [{"type": "text", "text": json.dumps(error_results, ensure_ascii=False)}]
 
 
-@mcp.tool(
-    description="Fetch the full contents of a search result document"
-)
+@mcp.tool(description="Fetch the full contents of a search result document")
 async def fetch(
     id: str,
     context: Context | None = None,
@@ -169,7 +155,7 @@ async def fetch(
             project=None,  # Let project resolution happen automatically
             page=1,
             page_size=10,  # Default pagination
-            context=context
+            context=context,
         )
 
         # Format the document for ChatGPT
@@ -178,12 +164,7 @@ async def fetch(
         logger.info(f"Fetch completed: id='{id}', content_length={len(document.get('text', ''))}")
 
         # Return in MCP content array format as required by OpenAI
-        return [
-            {
-                "type": "text",
-                "text": json.dumps(document, ensure_ascii=False)
-            }
-        ]
+        return [{"type": "text", "text": json.dumps(document, ensure_ascii=False)}]
 
     except Exception as e:
         logger.error(f"ChatGPT fetch failed for id '{id}': {e}")
@@ -192,11 +173,6 @@ async def fetch(
             "title": "Fetch Error",
             "text": f"Failed to fetch document: {str(e)[:200]}",
             "url": id,
-            "metadata": {"error": "Fetch failed"}
+            "metadata": {"error": "Fetch failed"},
         }
-        return [
-            {
-                "type": "text",
-                "text": json.dumps(error_document, ensure_ascii=False)
-            }
-        ]
+        return [{"type": "text", "text": json.dumps(error_document, ensure_ascii=False)}]

test-int/mcp/test_chatgpt_tools_integration.py

@@ -38,8 +38,7 @@ async def test_chatgpt_search_basic(mcp_server, app, test_project):
                 "title": "Machine Learning Fundamentals",
                 "folder": "ai",
                 "content": (
-                    "# Machine Learning Fundamentals\n\n"
-                    "Introduction to ML concepts and algorithms."
+                    "# Machine Learning Fundamentals\n\nIntroduction to ML concepts and algorithms."
                 ),
                 "tags": "ml,ai,fundamentals",
             },
@@ -66,8 +65,7 @@ async def test_chatgpt_search_basic(mcp_server, app, test_project):
                 "title": "Data Visualization Guide",
                 "folder": "data",
                 "content": (
-                    "# Data Visualization Guide\n\n"
-                    "Creating charts and graphs for data analysis."
+                    "# Data Visualization Guide\n\nCreating charts and graphs for data analysis."
                 ),
                 "tags": "visualization,data,charts",
             },
@@ -131,8 +129,7 @@ async def test_chatgpt_search_with_boolean_operators(mcp_server, app, test_proje
                 "title": "Python Web Frameworks",
                 "folder": "dev",
                 "content": (
-                    "# Python Web Frameworks\n\n"
-                    "Comparing Django and Flask for web development."
+                    "# Python Web Frameworks\n\nComparing Django and Flask for web development."
                 ),
                 "tags": "python,web,frameworks",
             },
@@ -376,7 +373,7 @@ async def test_chatgpt_tools_error_handling(mcp_server, app, test_project):
         )
 
         # Should still return MCP content array format
-        assert hasattr(search_result, 'content')
+        assert hasattr(search_result, "content")
         content_list = search_result.content
         assert isinstance(content_list, list)
         assert len(content_list) == 1
@@ -397,8 +394,7 @@ async def test_chatgpt_integration_workflow(mcp_server, app, test_project):
             {
                 "title": "API Design Best Practices",
                 "content": (
-                    "# API Design Best Practices\n\n"
-                    "RESTful API design principles and patterns."
+                    "# API Design Best Practices\n\nRESTful API design principles and patterns."
                 ),
                 "tags": "api,rest,design",
             },
@@ -456,4 +452,4 @@ async def test_chatgpt_integration_workflow(mcp_server, app, test_project):
         assert "API" in document_json["text"] or "api" in document_json["text"].lower()
 
         # Verify document has expected structure
-        assert document_json["metadata"]["format"] == "markdown"
+        assert document_json["metadata"]["format"] == "markdown"

tests/mcp/tools/test_chatgpt_tools.py

@@ -19,29 +19,29 @@ async def test_search_successful_results():
                 content="This is test content for document 1",
                 type=SearchItemType.ENTITY,
                 score=1.0,
-                file_path="/test/docs/test-doc-1.md"
+                file_path="/test/docs/test-doc-1.md",
             ),
             SearchResult(
                 title="Test Document 2",
                 permalink="docs/test-doc-2",
                 content="This is test content for document 2",
                 type=SearchItemType.ENTITY,
                 score=0.9,
-                file_path="/test/docs/test-doc-2.md"
-            )
+                file_path="/test/docs/test-doc-2.md",
+            ),
         ],
         current_page=1,
-        page_size=10
+        page_size=10,
     )
 
     with patch(
-        'basic_memory.mcp.tools.chatgpt_tools.search_notes.fn',
-        new_callable=AsyncMock
+        "basic_memory.mcp.tools.chatgpt_tools.search_notes.fn", new_callable=AsyncMock
     ) as mock_search:
         mock_search.return_value = mock_results
 
         # Import and call the actual function
         from basic_memory.mcp.tools.chatgpt_tools import search
+
         result = await search.fn("test query")
 
         # Verify MCP content array format
@@ -71,12 +71,12 @@ async def test_search_with_error_response():
     error_message = "# Search Failed - Invalid Syntax\n\nThe search query contains errors..."
 
     with patch(
-        'basic_memory.mcp.tools.chatgpt_tools.search_notes.fn',
-        new_callable=AsyncMock
+        "basic_memory.mcp.tools.chatgpt_tools.search_notes.fn", new_callable=AsyncMock
     ) as mock_search:
         mock_search.return_value = error_message
 
         from basic_memory.mcp.tools.chatgpt_tools import search
+
         result = await search.fn("invalid query")
 
         # Verify MCP content array format
@@ -109,12 +109,12 @@ async def test_fetch_successful_document():
 """
 
     with patch(
-        'basic_memory.mcp.tools.chatgpt_tools.read_note.fn',
-        new_callable=AsyncMock
+        "basic_memory.mcp.tools.chatgpt_tools.read_note.fn", new_callable=AsyncMock
     ) as mock_read:
         mock_read.return_value = document_content
 
         from basic_memory.mcp.tools.chatgpt_tools import fetch
+
         result = await fetch.fn("docs/test-document")
 
         # Verify MCP content array format
@@ -143,12 +143,12 @@ async def test_fetch_document_not_found():
 """
 
     with patch(
-        'basic_memory.mcp.tools.chatgpt_tools.read_note.fn',
-        new_callable=AsyncMock
+        "basic_memory.mcp.tools.chatgpt_tools.read_note.fn", new_callable=AsyncMock
     ) as mock_read:
         mock_read.return_value = error_content
 
         from basic_memory.mcp.tools.chatgpt_tools import fetch
+
         result = await fetch.fn("nonexistent-doc")
 
         # Verify MCP content array format
@@ -175,19 +175,19 @@ def test_format_search_results_for_chatgpt():
                 content="Content for document one",
                 type=SearchItemType.ENTITY,
                 score=1.0,
-                file_path="/test/docs/doc-one.md"
+                file_path="/test/docs/doc-one.md",
             ),
             SearchResult(
                 title="",  # Test empty title handling
                 permalink="docs/untitled",
                 content="Content without title",
                 type=SearchItemType.ENTITY,
                 score=0.8,
-                file_path="/test/docs/untitled.md"
-            )
+                file_path="/test/docs/untitled.md",
+            ),
         ],
         current_page=1,
-        page_size=10
+        page_size=10,
     )
 
     formatted = _format_search_results_for_chatgpt(mock_results)
@@ -219,10 +219,10 @@ def test_format_document_error_handling():
     """Test document formatting with error content."""
     from basic_memory.mcp.tools.chatgpt_tools import _format_document_for_chatgpt
 
-    error_content = "# Note Not Found: \"missing-doc\"\n\nDocument not found."
+    error_content = '# Note Not Found: "missing-doc"\n\nDocument not found.'
     result = _format_document_for_chatgpt(error_content, "missing-doc", "Missing Doc")
 
     assert result["id"] == "missing-doc"
     assert result["title"] == "Missing Doc"
     assert result["text"] == error_content
-    assert result["metadata"]["error"] == "Document not found"
+    assert result["metadata"]["error"] == "Document not found"

tests/sync/test_sync_service.py

@@ -639,7 +639,7 @@ async def test_sync_preserves_timestamps(
     entity_updated_epoch = file_entity.updated_at.timestamp()
 
     # Allow 2s difference on Windows due to filesystem timing precision
-    tolerance = 2 if os.name == 'nt' else 1
+    tolerance = 2 if os.name == "nt" else 1
     assert abs(entity_created_epoch - file_stats.st_ctime) < tolerance
     assert abs(entity_updated_epoch - file_stats.st_mtime) < tolerance  # Allow tolerance difference