Skip to content

Commit 8d6e536

Browse files
authored
Merge pull request #773 from bashtage/examples-typing
TYP: Small typing improvements
2 parents 3c27969 + a5c21d2 commit 8d6e536

3 files changed

Lines changed: 13 additions & 7 deletions

File tree

examples/multiple-comparison_examples.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@
332332
"better_models = pd.concat(\n",
333333
" [model_losses_df.mean(axis=0), model_losses_df.mean(axis=0)], axis=1\n",
334334
")\n",
335-
"better_models.columns = [\"Same or worse\", \"Better\"]\n",
335+
"better_models.columns = pd.Index([\"Same or worse\", \"Better\"])\n",
336336
"better = better_models.index.isin(stepm.superior_models)\n",
337337
"worse = np.logical_not(better)\n",
338338
"better_models.loc[better, \"Same or worse\"] = np.nan\n",

examples/unitroot_examples.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@
204204
"\n",
205205
"resids = pd.DataFrame(reg_res.resid)\n",
206206
"resids.index = default.index[6:]\n",
207-
"resids.columns = [\"resids\"]\n",
207+
"resids.columns = pd.Index([\"resids\"])\n",
208208
"fig = resids.plot()"
209209
]
210210
},

examples/univariate_volatility_scenarios.ipynb

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,9 @@
168168
"random_state = np.random.RandomState(1)\n",
169169
"\n",
170170
"\n",
171-
"def scenario_rng(size):\n",
171+
"def scenario_rng(\n",
172+
" size: tuple[int, int],\n",
173+
") -> np.ndarray[tuple[int, int], np.dtype[np.float64]]:\n",
172174
" shocks = random_state.standard_normal(size)\n",
173175
" shocks[:, :5] *= np.sqrt(2)\n",
174176
" return shocks\n",
@@ -197,13 +199,17 @@
197199
"metadata": {},
198200
"outputs": [],
199201
"source": [
200-
"class ScenarioBootstrapRNG(object):\n",
201-
" def __init__(self, shocks, random_state):\n",
202-
" self._shocks = np.asarray(shocks) # 1d\n",
202+
"class ScenarioBootstrapRNG:\n",
203+
" def __init__(\n",
204+
" self,\n",
205+
" shocks: np.ndarray[tuple[int], np.dtype[np.float64]],\n",
206+
" random_state: np.random.RandomState,\n",
207+
" ) -> None:\n",
208+
" self._shocks = shocks # 1d\n",
203209
" self._rs = random_state\n",
204210
" self.n = shocks.shape[0]\n",
205211
"\n",
206-
" def rng(self, size):\n",
212+
" def rng(self, size: int) -> np.ndarray[tuple[int], np.dtype[np.float64]]:\n",
207213
" idx = self._rs.randint(0, self.n, size=size)\n",
208214
" return self._shocks[idx]\n",
209215
"\n",

0 commit comments

Comments
 (0)