Skip to content

Commit e8f3bb2

Browse files
derekmaurocopybara-github
authored andcommitted
Add additional tests in str_split_test.cc
PiperOrigin-RevId: 884611329 Change-Id: I5944333d11c85867652fc5e596020381c445d562
1 parent 0a7fe7e commit e8f3bb2

3 files changed

Lines changed: 15 additions & 0 deletions

File tree

absl/strings/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1114,6 +1114,7 @@ cc_test(
11141114
"//absl/container:btree",
11151115
"//absl/container:flat_hash_map",
11161116
"//absl/container:node_hash_map",
1117+
"//absl/hash",
11171118
"@googletest//:gtest",
11181119
"@googletest//:gtest_main",
11191120
],

absl/strings/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -397,6 +397,7 @@ absl_cc_test(
397397
absl::dynamic_annotations
398398
absl::btree
399399
absl::flat_hash_map
400+
absl::hash
400401
absl::node_hash_map
401402
GTest::gmock_main
402403
)

absl/strings/str_split_test.cc

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
#include "absl/container/btree_set.h"
3737
#include "absl/container/flat_hash_map.h"
3838
#include "absl/container/node_hash_map.h"
39+
#include "absl/hash/hash.h"
3940
#include "absl/strings/string_view.h"
4041

4142
namespace {
@@ -422,6 +423,9 @@ TEST(Splitter, ConversionOperator) {
422423
TestConversionOperator<absl::btree_multiset<absl::string_view>>(splitter);
423424
TestConversionOperator<absl::btree_multiset<std::string>>(splitter);
424425
TestConversionOperator<std::unordered_set<std::string>>(splitter);
426+
TestConversionOperator<
427+
std::unordered_set<absl::string_view, absl::Hash<absl::string_view>>>(
428+
splitter);
425429

426430
// Tests conversion to map-like objects.
427431

@@ -455,6 +459,15 @@ TEST(Splitter, ConversionOperator) {
455459
splitter);
456460
TestMapConversionOperator<std::unordered_map<std::string, std::string>>(
457461
splitter);
462+
TestMapConversionOperator<std::unordered_map<
463+
absl::string_view, absl::string_view, absl::Hash<absl::string_view>>>(
464+
splitter);
465+
TestMapConversionOperator<std::unordered_map<absl::string_view, std::string,
466+
absl::Hash<absl::string_view>>>(
467+
splitter);
468+
TestMapConversionOperator<std::unordered_map<std::string, absl::string_view,
469+
absl::Hash<absl::string_view>>>(
470+
splitter);
458471
TestMapConversionOperator<
459472
absl::node_hash_map<absl::string_view, absl::string_view>>(splitter);
460473
TestMapConversionOperator<

0 commit comments

Comments
 (0)