From 5b67a24a671af4b154130447c1e98529d16b8c6a Mon Sep 17 00:00:00 2001 From: Bar Arnon Date: Wed, 11 Mar 2026 16:29:02 +0100 Subject: [PATCH] Revert "Merge pull request #45 from apiiro/barnon/fix-webhook-create-array-response" This reverts commit f8fd83257816e26833ed2d21961315585965efec, reversing changes made to c6d30e7914383b24c3ce6d61602122899fd3b75d. --- src/GitLabApiClient/GitLabApiClient.csproj | 2 +- src/GitLabApiClient/WebhookClient.cs | 19 +++---------------- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/src/GitLabApiClient/GitLabApiClient.csproj b/src/GitLabApiClient/GitLabApiClient.csproj index afa7a32b..404739c4 100644 --- a/src/GitLabApiClient/GitLabApiClient.csproj +++ b/src/GitLabApiClient/GitLabApiClient.csproj @@ -4,7 +4,7 @@ net8.0 10 Apiiro.GitLabApiClient - 0.1.45 + 0.1.44 Apiiro Apiiro GitLabApiClient diff --git a/src/GitLabApiClient/WebhookClient.cs b/src/GitLabApiClient/WebhookClient.cs index 3e2f4246..ff813239 100644 --- a/src/GitLabApiClient/WebhookClient.cs +++ b/src/GitLabApiClient/WebhookClient.cs @@ -1,13 +1,10 @@ using System.Collections.Generic; -using System.Linq; using System.Threading.Tasks; using GitLabApiClient.Internal.Http; using GitLabApiClient.Internal.Paths; using GitLabApiClient.Models.Projects.Responses; using GitLabApiClient.Models.Webhooks.Requests; using GitLabApiClient.Models.Webhooks.Responses; -using Newtonsoft.Json; -using Newtonsoft.Json.Linq; namespace GitLabApiClient { @@ -40,23 +37,13 @@ public async Task> GetAsync(ProjectId projectId) } /// - /// Create new webhook. - /// Some GitLab versions return a JSON array from POST /projects/:id/hooks - /// instead of a single object. We deserialize as JToken to handle both formats. + /// Create new webhook /// /// The ID, path or of the project. /// Create hook request. /// newly created hook - public async Task CreateAsync(ProjectId projectId, CreateWebhookRequest request) - { - var token = await _httpFacade.Post($"projects/{projectId}/hooks", request); - return token switch - { - JArray array => array.FirstOrDefault()?.ToObject(), - JObject obj => obj.ToObject(), - _ => null - }; - } + public async Task CreateAsync(ProjectId projectId, CreateWebhookRequest request) => + await _httpFacade.Post($"projects/{projectId}/hooks", request); /// /// Delete a webhook