Skip to content

Commit 42668b0

Browse files
committed
License: address the rc2 IPMC review
PJ Fanning's review of 2.2.0-incubating-rc2 found third-party files that LICENSE did not cover. Register them: - src/include/optimizer/hints.h duplicates structures from pg_hint_plan.c and carries NTT's notice; list it under pg_hint_plan. - googlemock's class generator in the gpcloud googletest copy is Apache-2.0, not googletest's BSD-3; say so. - getopt_long.h and pg_getopt.h carry the UC Regents notice of the getopt code already listed; add them to that entry. - The test_regex module's tests derive from Tcl's reg.test and point at src/backend/regex/COPYRIGHT; add them to the regex entry. - Add a section for the Autotools, pkg-config and Autoconf Archive files under config/, naming each file's licence. The GPL-licensed ones carry an exception for use in Autoconf-generated configure scripts, the basis of the ASF's build-tools allowance (LEGAL-290). Greenplum files carry the copyright notice of whoever owned the code when they were written: Greenplum, Inc. (about 1050 files), EMC Corporation (about 1100), Pivotal Software, VMware, Inc. and Broadcom, plus three gpMgmt scripts with a "Copyright (c) Metapa 2005" notice. The Greenplum section of LICENSE named only VMware; name all of them, and add Metapa (which merged with Didera in 2003 to form Greenplum) to the historical contributors in README.apache.md. In pom.xml, note where the Metapa and Broadcom notices come from next to the RAT patterns that classify them. Assisted-by: Claude Code
1 parent 2257219 commit 42668b0

3 files changed

Lines changed: 98 additions & 4 deletions

File tree

‎LICENSE‎

Lines changed: 95 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,9 @@ The PostgreSQL software includes:
244244
Code from the BSD C library, each file under its own University of
245245
California copyright notice and the 3-clause BSD terms (in some
246246
files the rescinded advertising clause is left as a numbered gap):
247+
src/include/getopt_long.h
247248
src/include/lib/sort_template.h
249+
src/include/pg_getopt.h
248250
src/port/bsearch_arg.c
249251
src/port/fls.c
250252
src/port/getopt.c
@@ -341,6 +343,7 @@ The PostgreSQL software includes:
341343

342344
src/backend/regex
343345
src/include/regex
346+
src/test/modules/test_regex (tests based on Tcl's tests/reg.test)
344347
see licenses/LICENSE-regex.txt
345348

346349
----------------------------
@@ -480,10 +483,20 @@ Copyright (c) 2004-2020 VMware, Inc. or its affiliates. All Rights Reserved.
480483

481484
All Rights Reserved.
482485

483-
Some ORCA query optimizer files that Greenplum Database added in 2024
484-
carry a "Copyright (C) 2024 Broadcom" or "Copyright (C) 2024 VMware by
485-
Broadcom" notice instead; they are part of Greenplum Database and are
486-
covered by the same license.
486+
Files that came from Greenplum Database carry the copyright notice of
487+
whoever owned the code when they were written: Greenplum, Inc., EMC
488+
Corporation, Pivotal Software, VMware, Inc., or, for some ORCA query
489+
optimizer files added in 2024, "Copyright (C) 2024 Broadcom" or
490+
"Copyright (C) 2024 VMware by Broadcom". Three management scripts carry
491+
an older "Copyright (c) Metapa 2005" notice; Metapa merged with Didera in
492+
2003 to form Greenplum:
493+
494+
gpMgmt/bin/gpinitsystem
495+
gpMgmt/bin/lib/gp_bash_functions.sh
496+
gpMgmt/bin/lib/gpcreateseg.sh
497+
498+
All of these files are part of Greenplum Database and are covered by the
499+
same license.
487500

488501
Greenplum Database is licensed under the Apache License Version 2.0
489502
(see LICENSE) and is based on the PostgreSQL Database Management System.
@@ -513,6 +526,13 @@ The Greenplum Database software includes:
513526
(see the Apache License above; also shipped in-tree as
514527
src/test/unit/cmockery/LICENSE.txt)
515528

529+
googlemock's class generator, copyright 2007-2009 Google Inc. and
530+
Neal Norwitz, bundled with the googletest copy below but under the
531+
Apache License rather than googletest's BSD license:
532+
gpcontrib/gpcloud/test/googletest/googlemock/scripts/generator
533+
(see the Apache License above; also shipped in-tree as
534+
gpcontrib/gpcloud/test/googletest/googlemock/scripts/generator/LICENSE)
535+
516536
----------------------------
517537
BSD 2 Clause License
518538

@@ -541,6 +561,8 @@ The Greenplum Database software includes:
541561
see licenses/LICENSE-googletest.txt
542562

543563
gpcontrib/pg_hint_plan/*
564+
src/include/optimizer/hints.h (duplicates structures from
565+
pg_hint_plan.c so the hint parser can be used outside the extension)
544566
see licenses/LICENSE-pg-hint-plan.txt
545567

546568
----------------------------
@@ -690,3 +712,72 @@ Apache Cloudberry includes codes from
690712
see licenses/LICENSE-amalgamate.txt
691713
(also shipped in-tree as
692714
contrib/pax_storage/src/cpp/contrib/tabulate/utils/amalgamate/LICENSE.md)
715+
716+
================================================================================
717+
Build system files under config/
718+
719+
These files come from the GNU Autotools (Autoconf, Automake and
720+
Libtool), pkg-config and the Autoconf Archive. The GPL-licensed ones
721+
carry an exception for use in configure scripts generated by Autoconf,
722+
which is the basis on which the ASF allows such build-tool files in its
723+
distributions (https://www.apache.org/legal/resolved.html#build-tools;
724+
see also LEGAL-290). Each file carries its full license notice, and the
725+
generated configure script includes expansions of these macros.
726+
727+
----------------------------
728+
GNU General Public License, with an exception for use in configure
729+
scripts generated by Autoconf
730+
731+
config/config.guess
732+
Copyright 1992-2021 Free Software Foundation, Inc.
733+
config/config.sub
734+
Copyright 1992-2021 Free Software Foundation, Inc.
735+
(GPL-3.0-or-later)
736+
737+
config/check_decls.m4
738+
(no copyright line of its own: based on commit
739+
82ef7805faffa151e724aa76c245ec590d174580 of Autoconf and
740+
distributed under Autoconf's license, GPL-3.0-or-later with
741+
the Autoconf Configure Script Exception 3.0)
742+
743+
config/libtool.m4
744+
Copyright (C) 1996-1999,2000 Free Software Foundation, Inc.
745+
(GPL-2.0-or-later)
746+
747+
config/pkg.m4
748+
Copyright © 2004 Scott James Remnant <scott@netsplit.com>.
749+
Copyright © 2012-2015 Dan Nicholson <dbn.lists@gmail.com>
750+
(GPL-2.0-or-later)
751+
752+
config/ax_pthread.m4, from the Autoconf Archive
753+
Copyright (c) 2008 Steven G. Johnson <stevenj@alum.mit.edu>
754+
Copyright (c) 2011 Daniel Richard G. <skunk@iSKUNK.ORG>
755+
(GPL-3.0-or-later with the Autoconf Macro exception)
756+
757+
----------------------------
758+
FSF All-Permissive License
759+
760+
Macros from the Autoconf Archive:
761+
762+
config/ax_compare_version.m4
763+
Copyright (c) 2008 Tim Toolan <toolan@ele.uri.edu>
764+
765+
config/ax_cxx_compile_stdcxx.m4
766+
Copyright (c) 2008 Benjamin Kosnik <bkoz@redhat.com>
767+
Copyright (c) 2012 Zack Weinberg <zackw@panix.com>
768+
Copyright (c) 2013 Roy Stogner <roystgnr@ices.utexas.edu>
769+
Copyright (c) 2014, 2015 Google Inc.; contributed by Alexey Sokolov <sokolov@google.com>
770+
Copyright (c) 2015 Paul Norman <penorman@mac.com>
771+
Copyright (c) 2015 Moritz Klammler <moritz@klammler.eu>
772+
Copyright (c) 2016, 2018 Krzesimir Nowak <qdlacz@gmail.com>
773+
Copyright (c) 2019 Enji Cooper <yaneurabeya@gmail.com>
774+
775+
config/ax_python_module.m4
776+
Copyright (c) 2008 Andrew Collier
777+
778+
----------------------------
779+
X11 License
780+
781+
config/install-sh
782+
Copyright (C) 1994 X Consortium
783+
(the Free Software Foundation's changes to it are in the public domain)

‎README.apache.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ This file is licensed under the GPL (Category X) and has been removed from the s
3131

3232
The following entities have contributed to the Greenplum-based source code under the Apache License 2.0:
3333

34+
- Metapa (merged with Didera in 2003 to form Greenplum)
3435
- Greenplum, Inc.
3536
- EMC Corporation
3637
- VMware, Inc.

‎pom.xml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2087,6 +2087,7 @@ code or new licensing patterns.
20872087
<licenseFamilyName>Apache License (Broadcom-derived)</licenseFamilyName>
20882088
<licenseFamilyCategory>BRDC</licenseFamilyCategory>
20892089
<patterns>
2090+
<!-- ORCA files Greenplum added in 2024, after Broadcom acquired VMware. -->
20902091
<pattern>Copyright (C) 2024 VMware by Broadcom.</pattern>
20912092
<pattern>Copyright (C) 2024 Broadcom</pattern>
20922093
</patterns>
@@ -2119,6 +2120,7 @@ code or new licensing patterns.
21192120
<pattern>Copyright (c) 2007 Greenplum Inc</pattern>
21202121
<pattern>Copyright (c) 2010, Greenplum Software</pattern>
21212122
<pattern>Copyright (c) Greenplum Inc 2010</pattern>
2123+
<!-- Metapa merged with Didera in 2003 to form Greenplum. -->
21222124
<pattern>Copyright (c) Metapa 2005. All Rights Reserved.</pattern>
21232125
<pattern>Copyright Greenplum 2008</pattern>
21242126
</patterns>

0 commit comments

Comments
 (0)