fix(test): make StoreOrderTest parallel-safe with unique broker names

- Use UUID-based unique broker name per test instance to avoid
  BrokerRegistry collisions between parallel runs
- Replace hardcoded vm://localhost with vm://<brokerName> connection
- Add TemporaryFolder in KahaDBStoreOrderTest to avoid shared
  data directory at target/activemq-data/kahadb/storeOrder
- Add waitUntilStarted()/waitUntilStopped() for proper lifecycle

Author: jeanouii

activemq-unit-tests/src/test/java/org/apache/activemq/store/StoreOrderTest.java

@@ -21,6 +21,7 @@
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
+import java.util.UUID;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.Executor;
 import java.util.concurrent.Executors;
@@ -56,6 +57,7 @@ public abstract class StoreOrderTest {
     protected BrokerService broker;
     private ActiveMQConnection connection;
     public Destination destination = new ActiveMQQueue("StoreOrderTest?consumer.prefetchSize=0");
+    protected final String brokerName = "StoreOrderTest-" + UUID.randomUUID().toString().substring(0, 8);
 
     protected abstract void setPersistentAdapter(BrokerService brokerService) throws Exception;
     protected void dumpMessages() throws Exception {}
@@ -107,7 +109,7 @@ public void setup() throws Exception {
     }
 
     public void initConnection() throws Exception {
-        ConnectionFactory connectionFactory = new ActiveMQConnectionFactory("vm://localhost?create=false");
+        ConnectionFactory connectionFactory = new ActiveMQConnectionFactory("vm://" + brokerName + "?create=false");
         connection = (ActiveMQConnection) connectionFactory.createConnection();
         connection.setWatchTopicAdvisories(false);
         connection.start();
@@ -120,6 +122,7 @@ public void stopBroker() throws Exception {
         }
         if (broker != null) {
             broker.stop();
+            broker.waitUntilStopped();
         }
     }
 
@@ -257,10 +260,12 @@ protected BrokerService startBroker(boolean deleteMessagesOnStartup) throws Exce
         configureBroker(newBroker);
         newBroker.setDeleteAllMessagesOnStartup(deleteMessagesOnStartup);
         newBroker.start();
+        newBroker.waitUntilStarted();
         return newBroker;
     }
 
     protected void configureBroker(BrokerService brokerService) throws Exception {
+        brokerService.setBrokerName(brokerName);
         setPersistentAdapter(brokerService);
         brokerService.setAdvisorySupport(false);
 

activemq-unit-tests/src/test/java/org/apache/activemq/store/kahadb/KahaDBStoreOrderTest.java

@@ -20,16 +20,20 @@
 
 import org.apache.activemq.broker.BrokerService;
 import org.apache.activemq.store.StoreOrderTest;
+import org.junit.Rule;
+import org.junit.rules.TemporaryFolder;
 
 //  https://issues.apache.org/activemq/browse/AMQ-2594
 public class KahaDBStoreOrderTest extends StoreOrderTest {
-    
+
+    @Rule
+    public TemporaryFolder tempFolder = new TemporaryFolder(new File("target"));
+
     @Override
     protected void setPersistentAdapter(BrokerService brokerService)
              throws Exception {
         KahaDBStore kaha = new KahaDBStore();
-        File directory = new File("target/activemq-data/kahadb/storeOrder");
-        kaha.setDirectory(directory);
+        kaha.setDirectory(tempFolder.newFolder("kahadb-storeOrder"));
         brokerService.setPersistenceAdapter(kaha);
     }
 }