Code Review Feedback

Andras · Andras · commit fbc4ef3d8a83 · 2026-04-10T12:14:53.000+03:00
diff --git a/packages/instantsearch-ui-components/src/components/autocomplete/createAutocompletePropGetters.ts b/packages/instantsearch-ui-components/src/components/autocomplete/createAutocompletePropGetters.ts
@@ -185,7 +185,7 @@ export function createAutocompletePropGetters({
 
       const actualDescendant = override.activeDescendant ?? activeDescendant;
 
-      if (!actualDescendant && override.query) {
+      if (!actualDescendant && override.query !== undefined) {
         onRefine(override.query);
       }
 

Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ export function createAutocompletePropGetters({`
`185`	`185`
`186`	`186`	`const actualDescendant = override.activeDescendant ?? activeDescendant;`
`187`	`187`
`188`		`- if (!actualDescendant && override.query) {`
	`188`	`+ if (!actualDescendant && override.query !== undefined) {`
`189`	`189`	`onRefine(override.query);`
`190`	`190`	`}`
`191`	`191`