types: Handles conversion of dictionary views. #45275

We handle the conversion by treating values/items/keys dictionary views
as simple lists.

Change-Id: Icb20bd9252785ac495ab76bd93d10eebb43d91ee
Reviewed-on: http://gerrit2.aldebaran.lan/1235
Reviewed-by: philippe.martin <philippe.martin@softbankrobotics.com>
Reviewed-by: jmonnon <jmonnon@aldebaran.com>
Tested-by: vincent.palancher <vincent.palancher@softbankrobotics.com>

Author: Vincent Palancher

src/pytypes.cpp

@@ -842,7 +842,7 @@ AnyReference unwrapAsRef(pybind11::object& obj)
                           ::py::set(obj).size()),
                         pybindObjPtr);
 
-  if (PyList_CheckExact(pyObjPtr))
+  if (PyList_CheckExact(pyObjPtr) || PyDictViewSet_Check(pyObjPtr) || PyDictValues_Check(pyObjPtr))
     return AnyReference(instance<types::ListInterface<::py::object, ::py::list>>(), pybindObjPtr);
 
   if (PyDict_CheckExact(pyObjPtr))

tests/test_types.cpp

@@ -412,3 +412,39 @@ TEST_F(TypePassing, LogLevel)
   registerService();
   EXPECT_EQ(qi::LogLevel_Info, getService().call<int>("func"));
 }
+
+TEST_F(TypePassing, DictViews)
+{
+  exec(
+      "class TestService:\n"
+      "    def func(self, kind):\n"
+      "        d = dict(one=1, two=2)\n"
+      "        if kind == 0:\n"
+      "            return d.keys()\n"
+      "        if kind == 1:\n"
+      "            return d.items()\n"
+      "        return d.values()\n"
+      );
+  registerService();
+
+  { // Keys
+    using Keys = std::set<std::string>;
+    const Keys expected{ "one", "two" };
+    EXPECT_EQ(expected, getService().call<Keys>("func", 0));
+  }
+
+  { // Items
+    using Items = std::set<std::pair<std::string, int>>;
+    const Items expected{ { "one", 1 }, { "two", 2 } };
+    EXPECT_EQ(expected, getService().call<Items>("func", 1));
+  }
+
+
+  { // Values
+    using Values = std::vector<int>;
+    const Values expected{ 1, 2 };
+    auto values = getService().call<Values>("func", 2);
+    std::sort(values.begin(), values.end());
+    EXPECT_EQ(expected, values);
+  }
+}