1) Don't ask for SSH Tunnel or Database server password if it is already saved.

2) Modified the generic error message from SSH Tunnel library.

Author: akshay-joshi

web/pgadmin/browser/server_groups/servers/__init__.py

@@ -1432,8 +1432,9 @@ def is_prompt_tunnel_password(self, server):
         """
         prompt_tunnel_password = True
         # In case of identity file check the value of tunnel_prompt_password.
-        if server.tunnel_identity_file is not None and \
-                server.tunnel_prompt_password != 1:
+        if server.tunnel_password is not None or \
+            (server.tunnel_identity_file is not None and
+             server.tunnel_prompt_password != 1):
             prompt_tunnel_password = False
 
         return prompt_tunnel_password
@@ -1595,7 +1596,7 @@ def connect(self, gid, sid, is_qt=False, server=None):
             )
         except Exception as e:
             return self.get_response_for_password(
-                server, 401, True, prompt_tunnel_password,
+                server, 401, not server.save_password, prompt_tunnel_password,
                 getattr(e, 'message', str(e)))
 
         if not status:
@@ -1607,7 +1608,8 @@ def connect(self, gid, sid, is_qt=False, server=None):
                 return internal_server_error(errmsg)
 
             return self.get_response_for_password(
-                server, 401, True, prompt_tunnel_password, errmsg)
+                server, 401, not server.save_password,
+                prompt_tunnel_password, errmsg)
         else:
             if save_password and config.ALLOW_SAVE_PASSWORD:
                 try:

web/pgadmin/static/js/Dialogs/ConnectServerContent.jsx

@@ -109,21 +109,23 @@ export default function ConnectServerContent({closeModal, data, onOK, setHeight,
         <DefaultButton data-test="close" startIcon={<CloseIcon />} onClick={()=>{
           closeModal();
         }} >{gettext('Cancel')}</DefaultButton>
-        <PrimaryButton ref={okBtnRef} data-test="save" startIcon={<CheckRoundedIcon />} onClick={()=>{
-          let postFormData = new FormData();
-          if(data.prompt_tunnel_password) {
-            postFormData.append('tunnel_password', formData.tunnel_password);
-            formData.save_tunnel_password &&
-              postFormData.append('save_tunnel_password', formData.save_tunnel_password);
-          }
-          if(data.prompt_password) {
-            postFormData.append('password', formData.password);
-            formData.save_password &&
-              postFormData.append('save_password', formData.save_password);
-          }
-          onOK?.(postFormData);
-          closeModal();
-        }} >{gettext('OK')}</PrimaryButton>
+        {(data.prompt_password || data.prompt_tunnel_password) && <>
+          <PrimaryButton ref={okBtnRef} data-test="save" startIcon={<CheckRoundedIcon />} onClick={()=>{
+            let postFormData = new FormData();
+            if(data.prompt_tunnel_password) {
+              postFormData.append('tunnel_password', formData.tunnel_password);
+              formData.save_tunnel_password &&
+                postFormData.append('save_tunnel_password', formData.save_tunnel_password);
+            }
+            if(data.prompt_password) {
+              postFormData.append('password', formData.password);
+              formData.save_password &&
+                postFormData.append('save_password', formData.save_password);
+            }
+            onOK?.(postFormData);
+            closeModal();
+          }} >{gettext('OK')}</PrimaryButton>
+        </>}
       </ModalFooter>
     </ModalContent>
   );

web/pgadmin/utils/driver/psycopg3/server_manager.py

@@ -612,8 +612,12 @@ def create_ssh_tunnel(self, tunnel_password):
             self.tunnel_created = True
         except BaseSSHTunnelForwarderError as e:
             current_app.logger.exception(e)
-            return False, gettext("Failed to create the SSH tunnel.\n"
-                                  "Error: {0}").format(str(e))
+            return False, gettext(
+                "Failed to create the SSH tunnel. Possible causes:\n"
+                "1. Enter the correct tunnel password (Clear saved password "
+                "if it has changed).\n 2. If using an identity file that "
+                "requires a password, enable “Prompt for Password?” in the "
+                "server dialog. \n 3. Verify the host address.")
 
         # Update the port to communicate locally
         self.local_bind_port = self.tunnel_object.local_bind_port