From 58d72e517bb9acd5b97b5b09160f3caf5cf97c75 Mon Sep 17 00:00:00 2001 From: Gilbert Gilb's Date: Sun, 22 Oct 2023 13:13:53 +0200 Subject: [PATCH 1/2] Fix race condition during fileio random request creation This was leading to creation of requests with incorrect file ids, which was causing fsync to fail on a bad file descriptor when the request was handled. fixes #400, fixes #430, fixes #431 --- src/tests/fileio/sb_fileio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/tests/fileio/sb_fileio.c b/src/tests/fileio/sb_fileio.c index 5a003769d..2bfd968f2 100644 --- a/src/tests/fileio/sb_fileio.c +++ b/src/tests/fileio/sb_fileio.c @@ -489,6 +489,7 @@ sb_event_t file_get_rnd_request(int thread_id) unsigned int i; sb_req.type = SB_REQ_TYPE_FILE; + SB_THREAD_MUTEX_LOCK(); if (test_mode == MODE_RND_RW) { From f58d97894e195f7ed44c62af619f83a795a13de1 Mon Sep 17 00:00:00 2001 From: Gilbert Gilb's Date: Sun, 22 Oct 2023 13:43:39 +0200 Subject: [PATCH 2/2] Fix typo --- src/tests/fileio/sb_fileio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/fileio/sb_fileio.c b/src/tests/fileio/sb_fileio.c index 2bfd968f2..d87a27592 100644 --- a/src/tests/fileio/sb_fileio.c +++ b/src/tests/fileio/sb_fileio.c @@ -477,7 +477,7 @@ sb_event_t file_get_seq_request(void) } -/* Request generatior for random tests */ +/* Request generator for random tests */ sb_event_t file_get_rnd_request(int thread_id)