Skip to content
This repository was archived by the owner on Oct 14, 2026. It is now read-only.

Commit d8d9f26

Browse files
jindaliiitaclaude
andcommitted
fix(tokowaka-client): checkEdgeOptimizeStatus returns only edgeOptimizeEnabled
blocked/statusCode are still computed internally to gate edgeOptimizeEnabled but no longer exposed in the return value. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 0057087 commit d8d9f26

2 files changed

Lines changed: 12 additions & 58 deletions

File tree

‎packages/spacecat-shared-tokowaka-client/src/index.js‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1347,7 +1347,7 @@ class TokowakaClient {
13471347
*
13481348
* @param {Object} site - Site entity
13491349
* @param {string} path - Path to check (e.g., '/products/chair')
1350-
* @returns {Promise<Object>} - `{ edgeOptimizeEnabled, blocked, statusCode? }`
1350+
* @returns {Promise<Object>} - `{ edgeOptimizeEnabled }`
13511351
*/
13521352
async checkEdgeOptimizeStatus(site, path) {
13531353
if (!isNonEmptyObject(site)) {
@@ -1409,8 +1409,6 @@ class TokowakaClient {
14091409

14101410
return {
14111411
edgeOptimizeEnabled,
1412-
blocked,
1413-
statusCode,
14141412
};
14151413
} catch (error) {
14161414
const isTimeout = error?.code === 'ETIMEOUT';

‎packages/spacecat-shared-tokowaka-client/test/index.test.js‎

Lines changed: 11 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -5225,11 +5225,7 @@ describe('TokowakaClient', () => {
52255225

52265226
const result = await esmockClient.checkEdgeOptimizeStatus(site, '/');
52275227

5228-
expect(result).to.deep.equal({
5229-
edgeOptimizeEnabled: true,
5230-
blocked: false,
5231-
statusCode: 200,
5232-
});
5228+
expect(result).to.deep.equal({ edgeOptimizeEnabled: true });
52335229
expect(tracingFetchStub).to.have.been.calledOnce;
52345230
expect(tracingFetchStub.firstCall.args[0]).to.equal('https://example.com/');
52355231
});
@@ -5247,11 +5243,7 @@ describe('TokowakaClient', () => {
52475243

52485244
const result = await esmockClient.checkEdgeOptimizeStatus(site, '/products');
52495245

5250-
expect(result).to.deep.equal({
5251-
edgeOptimizeEnabled: true,
5252-
blocked: false,
5253-
statusCode: 200,
5254-
});
5246+
expect(result).to.deep.equal({ edgeOptimizeEnabled: true });
52555247
expect(tracingFetchStub.firstCall.args[0]).to.equal('https://example.com/products');
52565248
});
52575249

@@ -5266,11 +5258,7 @@ describe('TokowakaClient', () => {
52665258

52675259
const result = await esmockClient.checkEdgeOptimizeStatus(site, '/');
52685260

5269-
expect(result).to.deep.equal({
5270-
edgeOptimizeEnabled: false,
5271-
blocked: false,
5272-
statusCode: 200,
5273-
});
5261+
expect(result).to.deep.equal({ edgeOptimizeEnabled: false });
52745262
});
52755263

52765264
it('should work with 404 status and edge optimize enabled', async () => {
@@ -5286,11 +5274,7 @@ describe('TokowakaClient', () => {
52865274

52875275
const result = await esmockClient.checkEdgeOptimizeStatus(site, '/not-found');
52885276

5289-
expect(result).to.deep.equal({
5290-
edgeOptimizeEnabled: true,
5291-
blocked: false,
5292-
statusCode: 404,
5293-
});
5277+
expect(result).to.deep.equal({ edgeOptimizeEnabled: true });
52945278
});
52955279

52965280
it('should send correct User-Agent header', async () => {
@@ -5550,11 +5534,7 @@ describe('TokowakaClient', () => {
55505534

55515535
const result = await promise;
55525536

5553-
expect(result).to.deep.equal({
5554-
edgeOptimizeEnabled: true,
5555-
blocked: false,
5556-
statusCode: 200,
5557-
});
5537+
expect(result).to.deep.equal({ edgeOptimizeEnabled: true });
55585538
expect(tracingFetchStub).to.have.been.calledTwice;
55595539
});
55605540

@@ -5578,11 +5558,7 @@ describe('TokowakaClient', () => {
55785558

55795559
const result = await promise;
55805560

5581-
expect(result).to.deep.equal({
5582-
edgeOptimizeEnabled: true,
5583-
blocked: false,
5584-
statusCode: 200,
5585-
});
5561+
expect(result).to.deep.equal({ edgeOptimizeEnabled: true });
55865562
expect(tracingFetchStub.callCount).to.equal(3);
55875563
});
55885564

@@ -5775,11 +5751,7 @@ describe('TokowakaClient', () => {
57755751

57765752
const result = await esmockClient.checkEdgeOptimizeStatus(site, '/error');
57775753

5778-
expect(result).to.deep.equal({
5779-
edgeOptimizeEnabled: true,
5780-
blocked: false,
5781-
statusCode: 500,
5782-
});
5754+
expect(result).to.deep.equal({ edgeOptimizeEnabled: true });
57835755
});
57845756
});
57855757

@@ -5808,11 +5780,7 @@ describe('TokowakaClient', () => {
58085780

58095781
const result = await esmockClient.checkEdgeOptimizeStatus(site, '/');
58105782

5811-
expect(result).to.deep.equal({
5812-
edgeOptimizeEnabled: false,
5813-
blocked: true,
5814-
statusCode: 403,
5815-
});
5783+
expect(result).to.deep.equal({ edgeOptimizeEnabled: false });
58165784
});
58175785

58185786
it('routing confirmed but soft-blocked (challenge page body) → edgeOptimizeEnabled: false, blocked: true', async () => {
@@ -5830,11 +5798,7 @@ describe('TokowakaClient', () => {
58305798

58315799
const result = await esmockClient.checkEdgeOptimizeStatus(site, '/');
58325800

5833-
expect(result).to.deep.equal({
5834-
edgeOptimizeEnabled: false,
5835-
blocked: true,
5836-
statusCode: 200,
5837-
});
5801+
expect(result).to.deep.equal({ edgeOptimizeEnabled: false });
58385802
});
58395803

58405804
it('routing confirmed and not blocked → edgeOptimizeEnabled: true, blocked: false', async () => {
@@ -5852,11 +5816,7 @@ describe('TokowakaClient', () => {
58525816

58535817
const result = await esmockClient.checkEdgeOptimizeStatus(site, '/');
58545818

5855-
expect(result).to.deep.equal({
5856-
edgeOptimizeEnabled: true,
5857-
blocked: false,
5858-
statusCode: 200,
5859-
});
5819+
expect(result).to.deep.equal({ edgeOptimizeEnabled: true });
58605820
});
58615821

58625822
it('routing not confirmed AND blocked → edgeOptimizeEnabled: false, blocked: true', async () => {
@@ -5870,11 +5830,7 @@ describe('TokowakaClient', () => {
58705830

58715831
const result = await esmockClient.checkEdgeOptimizeStatus(site, '/');
58725832

5873-
expect(result).to.deep.equal({
5874-
edgeOptimizeEnabled: false,
5875-
blocked: true,
5876-
statusCode: 403,
5877-
});
5833+
expect(result).to.deep.equal({ edgeOptimizeEnabled: false });
58785834
});
58795835
});
58805836
});

0 commit comments

Comments
 (0)