test(html-analyzer): harden map root handling

Process only outermost Google Maps runtime roots, assert preserved InfoWindow ordering, and document the browser shim and current header/body DOM assumptions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: anuj-adobe

packages/spacecat-shared-html-analyzer/src/html-filter.js

@@ -119,8 +119,14 @@ const MAPS_CONTROL_SELECTORS = [
  * @param {Element} element - DOM element to filter
  */
 function removeMapWidgets(element) {
-  element.querySelectorAll(MAPS_RUNTIME_ROOT_SELECTOR).forEach((mapRoot) => {
+  const mapRoots = Array.from(element.querySelectorAll(MAPS_RUNTIME_ROOT_SELECTOR));
+  const outermostMapRoots = mapRoots.filter((mapRoot) => !mapRoots.some(
+    (candidate) => candidate !== mapRoot && candidate.contains(mapRoot),
+  ));
+
+  outermostMapRoots.forEach((mapRoot) => {
     mapRoot.querySelectorAll('.gm-style-iw').forEach((infoWindow) => {
+      // Current Maps DOM uses separate header/body nodes; keep their document order.
       const contentParts = infoWindow.querySelectorAll('.gm-style-iw-ch, .gm-style-iw-d');
       const preservedNodes = contentParts.length ? contentParts : [infoWindow];
 
@@ -138,7 +144,12 @@ function removeMapWidgets(element) {
  * @param {CheerioAPI} $ - Cheerio instance
  */
 function removeMapWidgetsCheerio($) {
-  $(MAPS_RUNTIME_ROOT_SELECTOR).each((i, mapRoot) => {
+  const mapRoots = $(MAPS_RUNTIME_ROOT_SELECTOR).toArray();
+  const outermostMapRoots = mapRoots.filter((mapRoot) => !mapRoots.some(
+    (candidate) => candidate !== mapRoot && $.contains(candidate, mapRoot),
+  ));
+
+  outermostMapRoots.forEach((mapRoot) => {
     const $mapRoot = $(mapRoot);
     $mapRoot.find('.gm-style-iw').each((j, infoWindow) => {
       const $infoWindow = $(infoWindow);

packages/spacecat-shared-html-analyzer/test/index.test.js

@@ -23,7 +23,8 @@ import {
 } from '../src/index.js';
 
 function installBrowserDomParserShim() {
-  // This minimal shim supports selector/removal behavior only; fixtures must not include scripts.
+  // Cheerio-backed shim verifies call order only, not native NodeList or mutation semantics.
+  // It supports selector/removal behavior only; fixtures must not include scripts.
   const hadWindow = Object.hasOwn(globalThis, 'window');
   const hadDocument = Object.hasOwn(globalThis, 'document');
   const hadDOMParser = Object.hasOwn(globalThis, 'DOMParser');
@@ -39,6 +40,9 @@ function installBrowserDomParserShim() {
         const root = element ? $(element) : $.root();
         return root.find(selector).toArray().map((child) => createCheerioElement($, child));
       },
+      contains(child) {
+        return $.contains(element, child.cheerioElement);
+      },
       remove() {
         if (element) {
           $(element).remove();
@@ -425,6 +429,10 @@ describe('HTML Visibility Analyzer', () => {
               </div>
             </div>
             <div class="gm-style-iw">Legacy InfoWindow: Sevilla office.</div>
+            <div class="gm-style">
+              <div>Nested map runtime noise.</div>
+              <div class="gm-style-iw">Nested Valencia office.</div>
+            </div>
             <div class="gm-bundled-control">
               <div class="gmnoprint">
                 <div class="gm-svpc">Pegman</div>
@@ -446,12 +454,15 @@ describe('HTML Visibility Analyzer', () => {
       expect(text).to.include('Estación Repsol Centro');
       expect(text).to.include('Calle Mayor 1, Madrid');
       expect(text).to.include('Legacy InfoWindow: Sevilla office.');
+      expect(text).to.include('Nested Valencia office.');
       expect(text).to.not.include('Close window');
+      expect(text).to.not.include('Nested map runtime noise.');
       expect(text).to.not.include('Map data');
       expect(text).to.not.include('Pegman');
       expect(text).to.not.include('40.4168');
       expect(text).to.not.include('Zoom in');
       expect(text).to.not.include('Terms of Use');
+      expect(text.indexOf('Calle Mayor 1, Madrid')).to.be.lessThan(text.indexOf('Horario'));
     });
 
     it('should remove Google Maps tile fallback and keyboard shortcut text while preserving location content', async () => {