You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
flowchart LR
A["\"请求传参(filter_create_time, filter_update_time)\""] --> B["\"API服务层设置参数并响应更新时间\""]
B --> C["\"业务逻辑层传递更新时间至存储层\""]
C --> D["\"数据库查询与 SQL 条件更新\""]
B --> E["\"swagger文档更新\""]
Why: The suggestion correctly adds a nil check for w.WorkflowRecord before using its UpdateTime, which prevents a potential panic. The improvement is valid and enhances error handling, though it's a moderate change.
Why: The suggestion adds validation for the time string format using time.Parse, which improves data integrity when setting query parameters. It is a minor yet useful improvement, hence a slightly lower score.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
关联的 issue
https://github.com/actiontech/sqle-ee/issues/2884
描述你的变更
全局dashboard新增查询参数和展示列
确认项(pr提交后操作)
Tip
请在指定复审人之前,确认并完成以下事项,完成后✅
not_compatibleneed_update_doclink actiontech/sqle#3309
Description
添加创建时间、更新时间过滤参数至查询接口
新增更新时间字段到工单响应结构体
更新 SQL 查询及 swagger 文档支持新字段
Diagram Walkthrough
File Walkthrough
6 files
添加查询时间过滤参数与更新时间响应更新WorkflowRecord新增更新时间字段设置响应中更新时间字段增加更新时间查询条件及字段映射添加过滤参数与更新时间字段至响应更新查询 URL参数,传递更新时间过滤条件2 files
更新swagger.json,添加更新时间字段描述更新swagger.yaml,配置更新时间字段格式