Allow passing buffer size options to channel()#19
Merged
Conversation
The `SharedJsonBuffer` constructor already accepts a `{ size }` option,
but `channel()` doesn't expose it. This makes it impossible to send
large messages through a channel without hitting the default 64KB limit.
Thread the options bag through so callers can do:
const [tx, rx] = channel(32, { size: 1024 * 1024 * 5 });
Owner
|
Thanks! Looks good to me. I'll publish it in a new version soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optionsparameter through fromchannel()to the underlyingSharedJsonBufferconstructorSharedJsonBufferalready accepts{ size?: number }butchannel()wasn't exposing it, making it impossible to override the default 64KB buffer limitconst [tx, rx] = channel(32, { size: 1024 * 1024 * 5 })Context
When sending large messages (e.g. objects with thousands of keys) through a channel, the default 64KB
SharedJsonBufferoverflows withRangeError: offset is out of bounds. Related: #15