Skip to content

Consolidate the two Stripe layers and duplicated signature verification (F-20) #258

@perigrin

Description

@perigrin

Architecture review finding F-20.

Both Registry::Service::Stripe and Registry::Client::Stripe exist, and webhook-signature verification is implemented twice (each with its own _secure_compare). Maintaining two copies of security-critical crypto invites drift. Pick one Stripe layer and a single signature-verification implementation.

Evidence: lib/Registry/Client/Stripe.pm vs lib/Registry/Service/Stripe.pm:201-230 vs lib/Registry/Controller/Webhooks.pm:120-159.

Metadata

Metadata

Assignees

No one assigned

    Labels

    backendBackend/server-side developmentenhancementEnhancement to existing featurelow-impactLow business impactmediumMedium complexity implementationpaymentsPayment processing

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions