fix(asset-metadata): prevent broken image request for brand logo

nicomiguelino · claude · nicomiguelino · commit 132c08c70603 · 2026-04-08T21:35:25.000-07:00
- Remove empty `src` attribute to avoid spurious document URL request
- Add `hidden` attribute so no broken-image icon appears before JS loads
- Unhide the image only when a valid `logoUrl` is available

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/edge-apps/asset-metadata/index.html b/edge-apps/asset-metadata/index.html
@@ -92,7 +92,7 @@
           </div>
 
           <div class="card logo-card">
-            <img class="brand-logo" id="brand-logo" src="" alt="Brand Logo" />
+            <img class="brand-logo" id="brand-logo" alt="Brand Logo" hidden />
           </div>
 
           <div class="card version-card">
diff --git a/edge-apps/asset-metadata/src/main.ts b/edge-apps/asset-metadata/src/main.ts
@@ -60,6 +60,7 @@ document.addEventListener('DOMContentLoaded', async () => {
   const logoImg = document.getElementById('brand-logo') as HTMLImageElement
   if (logoImg && logoUrl) {
     logoImg.src = logoUrl
+    logoImg.hidden = false
   }
 
   setText('hostname', getHostname())

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,7 @@ document.addEventListener('DOMContentLoaded', async () => {`
`60`	`60`	`const logoImg = document.getElementById('brand-logo') as HTMLImageElement`
`61`	`61`	`if (logoImg && logoUrl) {`
`62`	`62`	`logoImg.src = logoUrl`
	`63`	`+ logoImg.hidden = false`
`63`	`64`	`}`
`64`	`65`
`65`	`66`	`setText('hostname', getHostname())`