Portfolio Summary main ui-grid broken and non-deterministic test

[perryr16]

Overview

There are a few issues with the portfolio summary

• The main ui-grid on the Portfolio Summary page never loads. It load forever.
• Portfolio summary scope var related_model_sort can often be undefined.

UI Grid bug

Bug

In the portoflio summary controller, get_all_labels() is called in the load_data fn. get_all_labels calls label_service.get_property_view_labels_by_cycle_goal which does not exist, causing JS to fail silently.

Solution

I believe the label_service function was supposed to be updated from get_property_view_labels_by_goal
to get_property_view_labels_by_cycle_goal. This allows the grid to load but causes other request/response errors that should be investigated

Undefined vars

$scope.related_model_sort = false should be initialized at the top of the file (line 81) and before the parse filter and sort for loop (line ~970)
$scope.column_sorts = [] should be initialized before the parse filter and sort for loop (line ~970)