OTP 21 build failure

[ilovezfs]

HEAD @ aa2330a

==> ./configure --prefix=/usr/local/Cellar/wrangler/HEAD-aa2330a_1
checking for gcc... clang
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether clang accepts -g... yes
checking for clang option to accept ISO C89... none needed
checking whether make sets $(MAKE)... yes
checking for erlc... /usr/local/opt/erlang/bin/erlc
checking for erl... /usr/local/opt/erlang/bin/erl
checking for erlc... /usr/local/opt/erlang/bin/erlc
configure: found 64-bit Erlang
checking for Erlang/OTP library installation base directory... ${exec_prefix}/lib/erlang/lib
configure: creating ./config.status
config.status: creating Makefile
config.status: creating c_src/suffixtree/Makefile
config.status: creating c_src/gsuffixtree/Makefile
==> make
"/usr/local/opt/erlang/bin/erlc" -o src src/wrangler_parse.yrl
"/usr/local/opt/erlang/bin/erlc" -pa ebin -I include -W -o ebin +debug_info src/wrangler_parse.erl
"/usr/local/opt/erlang/bin/erlc" -pa ebin -I include -W -o ebin +debug_info src/wrangler_expand_rule.erl
src/wrangler_expand_rule.erl:7: Warning: export_all flag enabled - all functions will be exported
src/wrangler_expand_rule.erl:542: Warning: erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace
"/usr/local/opt/erlang/bin/erlc" -pa ebin -I include -W -o ebin +debug_info src/wrangler_scan.erl
src/wrangler_scan.erl:28: Warning: export_all flag enabled - all functions will be exported
"/usr/local/opt/erlang/bin/erlc" -pa ebin -I include -W -o ebin +debug_info src/wrangler_epp_dodger.erl
"/usr/local/opt/erlang/bin/erlc" -pa ebin -I include -W -o ebin +debug_info src/wrangler_syntax.erl
"/usr/local/opt/erlang/bin/erlc" -pa ebin -I include -W -o ebin +debug_info src/wrangler_syntax_lib.erl
"/usr/local/opt/erlang/bin/erlc" -pa ebin -I include -W -o ebin +debug_info src/wrangler_misc.erl
"/usr/local/opt/erlang/bin/erlc" -pa ebin -I include -W -o ebin +debug_info src/api_ast_traverse.erl
"/usr/local/opt/erlang/bin/erlc" -pa ebin -I include -W -o ebin +debug_info src/api_refac.erl
src/api_refac.erl: error in parse transform 'wrangler_expand_rule': {{badrecord,class_qualifier},
                                                  [{erl_syntax,
                                                    class_qualifier_argument,
                                                    1,
                                                    [{file,"erl_syntax.erl"},
                                                     {line,6779}]},
                                                   {erl_syntax,subtrees,1,
                                                    [{file,"erl_syntax.erl"},
                                                     {line,7766}]},
                                                   {wrangler_expand_rule,
                                                    '-transform/4-fun-0-',4,
                                                    [{file,
                                                      "src/wrangler_expand_rule.erl"},
                                                     {line,527}]},
                                                   {wrangler_expand_rule,map,
                                                    2,
                                                    [{file,
                                                      "src/wrangler_expand_rule.erl"},
                                                     {line,558}]},
                                                   {wrangler_expand_rule,
                                                    '-transform/4-fun-0-',4,
                                                    [{file,
                                                      "src/wrangler_expand_rule.erl"},
                                                     {line,532}]},
                                                   {wrangler_expand_rule,map,
                                                    2,
                                                    [{file,
                                                      "src/wrangler_expand_rule.erl"},
                                                     {line,558}]},
                                                   {wrangler_expand_rule,map,
                                                    2,
                                                    [{file,
                                                      "src/wrangler_expand_rule.erl"},
                                                     {line,564}]},
                                                   {wrangler_expand_rule,
                                                    '-transform/4-fun-0-',4,
                                                    [{file,
                                                      "src/wrangler_expand_rule.erl"},
                                                     {line,532}]}]}
make: *** [ebin/api_refac.beam] Error 1
rm src/wrangler_parse.erl

[huiqing]

Thanks for reporting the issue. I shall try to fix it when time allows.

[neeraj9]

The exact error in case it helps in faster resolution is for the following form.

Form = {tree,class_qualifier,
           {attr,
               {0,0},
               [{syntax_path,clause_pattern},
                {env,
                    [{'File',1255},{'Fun',1255},{'Rules',1255},{'Tree',1255}]},
                {bound,[{'_E1',1260},{'_E2',1260}]},
                {free,[]}],
               none},
           {class_qualifier,
               {wrapper,variable,
                   {attr,1260,
                       [{syntax_path,class_qualifier_class},
                        {env,
                            [{'File',1255},
                             {'Fun',1255},
                             {'Rules',1255},
                             {'Tree',1255}]},
                        {bound,[{'_E1',1260}]},
                        {free,[]},
                        {def,[1260]},
                        {use,[1260]}],
                       none},
                   {var,1260,'_E1'}},
               {wrapper,variable,
                   {attr,1260,
                       [{syntax_path,class_qualifier_body},
                        {env,
                            [{'File',1255},
                             {'Fun',1255},
                             {'Rules',1255},
                             {'Tree',1255},
                             {'_E1',1260}]},
                        {bound,[{'_E2',1260}]},
                        {free,[]},
                        {def,[1260]},
                        {use,[1260]}],
                       none},
                   {var,1260,'_E2'}}}}
src/api_refac.erl: error in parse transform 'wrangler_expand_rule': {{badrecord,class_qualifier},
                                                  [{erl_syntax,
                                                    class_qualifier_argument,
                                                    1,
                                                    [{file,"erl_syntax.erl"},
                                                     {line,6779}]},
                                                   {erl_syntax,subtrees,1,
                                                    [{file,"erl_syntax.erl"},
                                                     {line,7766}]},
                                                   {wrangler_expand_rule,
                                                    '-transform/4-fun-0-',4,
                                                    [{file,
                                                      "src/wrangler_expand_rule.erl"},
                                                     {line,528}]},
                                                   {wrangler_expand_rule,map,
                                                    2,
                                                    [{file,
                                                      "src/wrangler_expand_rule.erl"},
                                                     {line,559}]},
                                                   {wrangler_expand_rule,
                                                    '-transform/4-fun-0-',4,
                                                    [{file,
                                                      "src/wrangler_expand_rule.erl"},
                                                     {line,533}]},
                                                   {wrangler_expand_rule,map,
                                                    2,
                                                    [{file,
                                                      "src/wrangler_expand_rule.erl"},
                                                     {line,559}]},
                                                   {wrangler_expand_rule,map,
                                                    2,
                                                    [{file,
                                                      "src/wrangler_expand_rule.erl"},
                                                     {line,565}]},
                                                   {wrangler_expand_rule,
                                                    '-transform/4-fun-0-',4,
                                                    [{file,
                                                      "src/wrangler_expand_rule.erl"},
                                                     {line,533}]}]}
Makefile:124: recipe for target 'ebin/api_refac.beam' failed
make: *** [ebin/api_refac.beam] Error 1

[neeraj9]

Additional notes:

The issue is due to stacktrace changes in OTP-21, wherein class_qualifier requires it apart from argument and body. see https://github.com/erlang/otp/blob/master/lib/syntax_tools/src/erl_syntax.erl

The specific change in erl_syntax to accommodate stacktrace changes is at erlang/otp@9dce8fe

		class_qualifier ->
                    [[class_qualifier_argument(T)],
                     [class_qualifier_body(T)],
                     [class_qualifier_stacktrace(T)]];

I wonder why wrangler has its own wrangler_syntax.erl?

[huiqing]

Thanks for the info, and I’m sorry for the delay. I’ll try to fix this next week when I have a few days off work. Regards, Huiqing From: Neeraj [mailto:notifications@github.com] Sent: 01 August 2018 06:55 To: RefactoringTools/wrangler <wrangler@noreply.github.com> Cc: Li,H,Huiqing,TLC4 R <huiqing.li@bt.com>; Comment <comment@noreply.github.com> Subject: Re: [RefactoringTools/wrangler] OTP 21 build failure (#87) Additional notes: The issue is due to stacktrace changes in OTP-21, wherein class_qualifier requires it apart from argument and body. see https://github.com/erlang/otp/blob/master/lib/syntax_tools/src/erl_syntax.erl class_qualifier -> [[class_qualifier_argument(T)], [class_qualifier_body(T)], [class_qualifier_stacktrace(T)]]; I wonder why wrangler has its own wrangler_syntax.erl? — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#87 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAk6X-uDTywSiKTHO-p0f7u2LeUDaQWKks5uMULBgaJpZM4UvZzv>.

[neeraj9]

FWIW I have a hackish implementation to get around OTP-21. This works for couple of cases but I spent only couple of minutes hacking it so would be buggy.

• https://github.com/neeraj9/wrangler/tree/dev-otp-21
• neeraj9@9a0a0c3

[paulo-ferraz-oliveira]

What's the maintenance range for this repo? The README doesn't mention it, I believe, and neither does rebar.config (there's a flag - {minimum_otp_vsn, "<vsn>"}. - that comes quite handy in these occasions), but given OTP's and rebar3's is I'd be surprised if they were still maintaining 21.