fix: Handle MaaS acronym in class-generator filename generation (#2665)

* fix: Handle MaaS acronym in class-generator filename generation

Fixes #2664

* fix: Replace sys.exit with raise ValueError for filename validation

Author: myakove

class_generator/core/generator.py

@@ -2,6 +2,7 @@
 
 import filecmp
 import os
+import re
 from pathlib import Path
 from typing import Any
 
@@ -55,6 +56,16 @@ def generate_resource_file_from_dict(
 
     output = "# Generated using https://github.com/RedHatQE/openshift-python-wrapper/blob/main/scripts/resource/README.md\n\n"
     formatted_kind_str = convert_camel_case_to_snake_case(name=resource_dict["kind"])
+
+    if re.search(r"_[a-z]_", formatted_kind_str):
+        msg = (
+            f"'{resource_dict['kind']}' produced invalid filename '{formatted_kind_str}.py'.\n"
+            f"Add '{resource_dict['kind']}' acronym to 'normalize_acronyms' dict in:\n"
+            f"  ocp_resources/utils/utils.py -> convert_camel_case_to_snake_case()"
+        )
+        LOGGER.error(msg)
+        raise ValueError(msg)
+
     _file_suffix: str = f"{'_' + output_file_suffix if output_file_suffix else ''}"
 
     if add_tests:
@@ -94,8 +105,10 @@ def generate_resource_file_from_dict(
         output += rendered
 
     if dry_run:
+        console = Console()
+        console.print(f"\n[bold green]Would create file:[/bold green] {_output_file}")
         _code = Syntax(code=output, lexer="python", line_numbers=True)
-        Console().print(_code)
+        console.print(_code)
 
     else:
         write_and_format_rendered(filepath=_output_file, output=output)

ocp_resources/utils/utils.py

@@ -88,6 +88,13 @@ def convert_camel_case_to_snake_case(name: str) -> str:
     if name.lower() in do_not_process_list:
         return name.lower()
 
+    # Known mixed-case acronyms that should be treated as single words.
+    # e.g., "MaaS" (Metal-as-a-Service) should convert to "maas", not "maa_s".
+    normalize_acronyms = {"MaaS": "Maas"}
+
+    for acronym, replacement in normalize_acronyms.items():
+        name = name.replace(acronym, replacement)
+
     formatted_str: str = ""
 
     if name.islower():

tests/test_camelcase_to_snake.py

@@ -32,6 +32,21 @@
             "data_volume_ttl_seconds",
             id="combined_uppercase_word_followed_by_uppercase_word_is_last_ends_with_lowercase",
         ),
+        pytest.param(
+            "MaaSModelRef",
+            "maas_model_ref",
+            id="mixed_case_acronym_maas_with_following_words",
+        ),
+        pytest.param(
+            "MaaSAuthPolicy",
+            "maas_auth_policy",
+            id="mixed_case_acronym_maas_auth_policy",
+        ),
+        pytest.param(
+            "MaaSSubscription",
+            "maas_subscription",
+            id="mixed_case_acronym_maas_subscription",
+        ),
     ],
 )
 def test_convert_camel_case_to_snake_case(camel_case_str, expected):