Skip to content

Commit 5e5b953

Browse files
committed
Remove hardcoded path to database in old scripts
- Switch to using rmgpy settings database.directory - Also removed the git history saving in kineticGroups.py script
1 parent 24cf740 commit 5e5b953

3 files changed

Lines changed: 10 additions & 13 deletions

File tree

scripts/evansPolanyi.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,9 +197,10 @@ def onpick(event):
197197

198198
print 'Loading RMG database...'
199199
from rmgpy.data.rmg import RMGDatabase
200+
from rmgpy import settings
200201
database = RMGDatabase()
201-
database.load('input')
202-
202+
database.load(settings['database.directory'], kineticsFamilies='all', kineticsDepositories='all')
203+
203204
try:
204205
depositories = [database.kinetics.depository[label] for label in args.depository]
205206
except KeyError:

scripts/kineticsGroups.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,15 @@
2323
from rmgpy.kinetics import Arrhenius, ArrheniusEP, KineticsData
2424
from rmgpy.data.base import getAllCombinations
2525
from rmgpy.species import Species
26-
27-
from importOldDatabase import getUsername
28-
user = getUsername()
26+
from rmgpy import settings
2927

3028
################################################################################
3129

3230
def loadDatabase():
3331
print 'Loading RMG database...'
3432
from rmgpy.data.rmg import RMGDatabase
3533
database = RMGDatabase()
36-
database.load('input')
34+
database.load(settings['database.directory'], kineticsFamilies='all', kineticsDepositories='all')
3735
return database
3836

3937
def convertKineticsToPerSiteBasis(kinetics, degeneracy):
@@ -143,12 +141,8 @@ def generate(args):
143141
changed = family.groups.generateGroupAdditivityValues(trainingSet, kunits, method=method)
144142

145143
if changed:
146-
# Add a note to the history of each changed item indicating that we've generated new group values
147-
event = [time.asctime(),user,'action','Generated new group additivity values for this entry.']
148-
for entry in family.groups.entries.values():
149-
entry.history.append(event)
150144
# Save the new group values to disk
151-
family.saveGroups(os.path.join('input', 'kinetics', 'families', label, 'groups.py'))
145+
family.saveGroups(os.path.join(settings['database.directory'], 'kinetics', 'families', label, 'groups.py'))
152146

153147
################################################################################
154148

scripts/kineticsTraining.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,8 @@ def generateEntry(reaction, kinetics, index, ci):
381381
Tmax = 2000
382382

383383
def getPath(family, index):
384-
return os.path.join(os.path.dirname(os.path.abspath(__file__)), 'input', 'kinetics', 'families', family, 'training', '{0}.py'.format(index))
384+
from rmgpy import settings
385+
return os.path.join(settings['database.directory'], 'kinetics', 'families', family, 'training', '{0}.py'.format(index))
385386

386387
def generate(args):
387388
"""
@@ -453,6 +454,7 @@ def evaluate(args):
453454
if __name__ == '__main__':
454455

455456
import argparse
457+
from rmgpy import settings
456458

457459
parser = argparse.ArgumentParser()
458460
subparsers = parser.add_subparsers(dest='command', help='')
@@ -471,7 +473,7 @@ def evaluate(args):
471473

472474
args = parser.parse_args()
473475

474-
loadThermoDatabase(os.path.join(os.path.dirname(os.path.abspath(__file__)), 'input', 'thermo'))
476+
loadThermoDatabase(os.path.join(settings['database.directory'], 'thermo'))
475477

476478
try:
477479
args.run(args)

0 commit comments

Comments
 (0)