Skip to content

Commit dcef9ab

Browse files
JacksonBurnshwpang
andauthored
Apply suggestions from code review
- clearer error messages Co-authored-by: Hao-Wei Pang <45482070+hwpang@users.noreply.github.com>
1 parent 24a0731 commit dcef9ab

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

rmgpy/pdep/sls.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
from diffeqpy import de
5151
from julia import Main
5252
except Exception as e:
53-
warnings.warn(
53+
logging.info(
5454
f"Unable to import Julia dependencies, original error: {str(e)}"
5555
". Master equation method 'ode' will not be available on this execution."
5656
)
@@ -163,7 +163,7 @@ def get_rate_coefficients_SLS(network, T, P, method="mexp", neglect_high_energy_
163163
if NO_JULIA:
164164
raise RuntimeError(
165165
"Required Julia dependencies for method 'ode' are not installed.\n"
166-
"Please check your installation (https://reactionmechanismgenerator.github.io/RMG-Py/users/rmg/installation/index.html)."
166+
"Please follow the steps to install Julia dependencies at https://reactionmechanismgenerator.github.io/RMG-Py/users/rmg/installation/anacondaDeveloper.html."
167167
)
168168
f = Main.eval(
169169
"""

rmgpy/rmg/input.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1562,7 +1562,7 @@ def read_input_file(path, rmg0):
15621562
if NO_JULIA:
15631563
logging.error(
15641564
"During runtime, import of Julia dependencies failed. To use phase systems and RMS reactors, install RMG-Py with RMS."
1565-
" (https://reactionmechanismgenerator.github.io/RMG-Py/users/rmg/installation/index.html)"
1565+
" (https://reactionmechanismgenerator.github.io/RMG-Py/users/rmg/installation/anacondaDeveloper.html)"
15661566
)
15671567
logging.exception(e)
15681568
raise

0 commit comments

Comments
 (0)