Skip to content

Commit bd17021

Browse files
authored
Merge pull request #2829 from ReactionMechanismGenerator/adapt_rms_examples
Update Jupyter Notebooks to call RMS using juliacall
2 parents 73eab91 + 4ea146c commit bd17021

6 files changed

Lines changed: 694 additions & 121 deletions

File tree

examples/rmg/catalysis/ch4_o2/simulate_ch4o2cat_RMS.ipynb

Lines changed: 237 additions & 38 deletions
Large diffs are not rendered by default.

examples/rmg/superminimal/sensitivity_analysis_superminimal_RMS.ipynb

Lines changed: 171 additions & 48 deletions
Large diffs are not rendered by default.

examples/rmg/superminimal/simulation_flux_rop_superminimal_RMS.ipynb

Lines changed: 154 additions & 21 deletions
Large diffs are not rendered by default.

examples/rmg/superminimal/tolerance_superminimal_RMS.ipynb

Lines changed: 125 additions & 12 deletions
Large diffs are not rendered by default.

rmgpy/rmg/main.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -768,8 +768,8 @@ def register_listeners(self, requires_rms=False):
768768
"""
769769

770770
self.attach(ChemkinWriter(self.output_directory))
771-
if requires_rms:
772-
self.attach(RMSWriter(self.output_directory))
771+
772+
self.attach(RMSWriter(self.output_directory))
773773

774774
if self.generate_output_html:
775775
self.attach(OutputHTMLWriter(self.output_directory))

test/rmgpy/rmg/mainTest.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,11 @@ def test_rmg_seed_edge_library_creation(self):
119119
"""Test that edge seed mechanisms are created in the correct database locations."""
120120
assert os.path.exists(self.seedKinetics)
121121

122+
def test_rmg_rms_mechanism_files_creation(self):
123+
"""Test that rms mechanisms are created in the correct location."""
124+
assert os.path.exists(os.path.join(self.rmg.output_directory,"rms"))
125+
assert len(os.listdir(os.path.join(self.rmg.output_directory,"rms"))) != 0
126+
122127
def test_rmg_seed_works(self):
123128
"""Test that the created seed libraries work.
124129

0 commit comments

Comments
 (0)