Skip to content

Commit 97aacfa

Browse files
wenshaoclaude
andcommitted
fix(review): enforce correct verdict flag + exclude Nice to have from PR
Three issues found from real /review output on PR #2921: 1. Critical findings but verdict submitted as --comment instead of --request-changes. Added explicit: "Do NOT use --comment when verdict is Request changes — this loses the blocking status." 2. Nice to have findings appeared in PR summary. Added: "Do NOT include Nice to have findings" to all summary rules. 3. Clarified that failed-inline summary should only contain Critical/Suggestion, never Nice to have. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent bb85768 commit 97aacfa

File tree

1 file changed

+3
-3
lines changed
  • packages/core/src/skills/bundled/review

1 file changed

+3
-3
lines changed

packages/core/src/skills/bundled/review/SKILL.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -460,9 +460,9 @@ If posting an inline comment fails (e.g., line not part of the diff, auth error)
460460

461461
Only call `gh pr review` in these cases:
462462

463-
- **Approve** or **Request changes**submit with a **one-line** body only. Do NOT include analysis, findings summary, or explanations — those are already in the inline comments. Example: "Approve — LGTM.\n\n*Reviewed by {{model}} via Qwen Code /review*" or "Request changes — see inline comments.\n\n*Reviewed by {{model}} via Qwen Code /review*". These verdicts carry approval/blocking status.
464-
- **Comment** but **some** inline comments failed → submit with **only the failed findings** in the body. Do NOT repeat findings that were already posted as inline comments. Do NOT include internal stats (agent count, raw/confirmed numbers). Keep it concise.
465-
- **No** inline comments posted (all failed or terminal-only) → submit with full findings summary (no stats).
463+
- **Approve** or **Request changes**use the correct `gh pr review` flag: `--approve` for Approve, `--request-changes` for Request changes. Do NOT use `--comment` when the verdict is Request changes — this is wrong and loses the blocking status. Body should be **one-line** if all findings were posted inline, or include **only the failed inline findings** if some could not be posted. Do NOT include analysis, section headers, or internal stats. Do NOT include Nice to have findings (terminal-only). Example: "Request changes — see inline comments.\n\n*Reviewed by {{model}} via Qwen Code /review*".
464+
- **Comment** with no Critical findings, but **some** inline comments failed → submit with `--comment` and **only the failed findings** (Critical/Suggestion) in the body. Do NOT repeat findings already posted inline. Do NOT include Nice to have findings.
465+
- **No** inline comments posted (all failed or terminal-only) → submit with full findings summary (Critical/Suggestion only, no Nice to have, no stats).
466466

467467
Use `write_file` to create `/tmp/qwen-review-{target}-summary.txt` when needed. Use the **pre-fix verdict** from Step 7:
468468

0 commit comments

Comments
 (0)