Skip to content

Commit 8b15e2a

Browse files
authored
Merge pull request #2835 from chinesepowered/ext-await
fix(extensions): await async calls in extension refresh chain
2 parents 6d9ee19 + c05e503 commit 8b15e2a

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

packages/core/src/extension/extensionManager.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1073,7 +1073,7 @@ export class ExtensionManager {
10731073
'success',
10741074
),
10751075
);
1076-
this.refreshTools();
1076+
await this.refreshTools();
10771077
} else {
10781078
logExtensionInstallEvent(
10791079
telemetryConfig,
@@ -1186,7 +1186,7 @@ export class ExtensionManager {
11861186
if (isUpdate) return;
11871187

11881188
this.removeEnablementConfig(extension.name);
1189-
this.refreshTools();
1189+
await this.refreshTools();
11901190

11911191
logExtensionUninstall(
11921192
telemetryConfig,
@@ -1337,7 +1337,7 @@ export class ExtensionManager {
13371337
async refreshMemory(): Promise<void> {
13381338
if (!this.config) return;
13391339
// refresh mcp servers
1340-
this.config.getToolRegistry().restartMcpServers();
1340+
await this.config.getToolRegistry().restartMcpServers();
13411341
// refresh skills
13421342
this.config.getSkillManager()?.refreshCache();
13431343
// refresh subagents
@@ -1349,7 +1349,7 @@ export class ExtensionManager {
13491349
async refreshTools(): Promise<void> {
13501350
if (!this.config) return;
13511351
// FIXME: restart all mcp servers now, this can be optimized by only restarting changed ones at here
1352-
this.refreshMemory();
1352+
await this.refreshMemory();
13531353
}
13541354
}
13551355

0 commit comments

Comments
 (0)