Merge pull request #4038 from ProjectMirador/vite-cleanup

Vite cleanup

Author: cbeer

.eslintrc

@@ -1,20 +1,59 @@
 {
-  "env": {
-    "jest/globals": true
+  "parserOptions": {
+    "ecmaVersion": 2022,
+    "sourceType": "module",
+    "ecmaFeatures": {
+      "jsx": true
+    }
   },
-  "extends": ["airbnb","react-app", "plugin:jest-dom/recommended", "plugin:testing-library/react"],
+  "extends": [
+    "airbnb",
+    "plugin:react/recommended",
+    "plugin:react-hooks/recommended",
+    "plugin:testing-library/react"
+  ],
   "globals": {
     "page": true,
     "document": true,
-    "vi": true,
+    "vi": true
   },
-  "plugins": ["jest", "jest-dom", "react", "react-hooks", "testing-library"],
+  "plugins": [
+    "react", 
+    "react-hooks",
+    "testing-library"
+  ],
   "rules": {
     "import/no-unresolved": [
       2, { "ignore": ["test-utils"] }
     ],
     "import/prefer-default-export": "off",
     "no-console": "off",
+    "no-unused-expressions": ["error", { "allowShortCircuit": true, "allowTernary": true }],
+    "no-unused-vars": "off",
+    "no-undef": "off",
+    "no-restricted-syntax": ["warn", "WithStatement"],
+    "no-restricted-globals": ["error"],
+    "eqeqeq": ["warn", "smart"],
+    "no-use-before-define": [
+      "warn",
+      {
+        "functions": false,
+        "classes": false,
+        "variables": false
+      },
+    ],
+    "no-mixed-operators": [
+      "warn",
+      {
+        "groups": [
+          ["&", "|", "^", "~", "<<", ">>", ">>>"],
+          ["==", "!=", "===", "!==", ">", ">=", "<", "<="],
+          ["&&", "||"],
+          ["in", "instanceof"],
+        ],
+        "allowSamePrecedence": false,
+      },
+    ],
     "react/jsx-filename-extension": [1, { "extensions": [".js", ".jsx"] }],
     "require-jsdoc": ["error", {
       "require": {

package.json

@@ -92,10 +92,8 @@
     "chalk": "^5.3.0",
     "eslint": "^8.11.0",
     "eslint-config-airbnb": "^19.0.4",
-    "eslint-config-react-app": "^7.0.0",
     "eslint-plugin-flowtype": "^8.0.3",
     "eslint-plugin-import": "^2.25.4",
-    "eslint-plugin-jest": "^27.1.5",
     "eslint-plugin-jest-dom": "^5.1.0",
     "eslint-plugin-jsx-a11y": "^6.4.1",
     "eslint-plugin-react": "^7.29.4",
@@ -104,10 +102,6 @@
     "glob": "^10.3.0",
     "happy-dom": "^15.11.3",
     "http-server": "^14.1.0",
-    "jest": "^29.3.1",
-    "jest-environment-jsdom": "^29.4.3",
-    "jest-fetch-mock": "^3.0.0",
-    "jest-puppeteer": "^10.1.0",
     "jsdom": "^25.0.0",
     "puppeteer": "^23.0.0",
     "react": "^18.0.0",

src/components/PluginHook.js

@@ -18,3 +18,5 @@ export const PluginHook = forwardRef((props, ref) => {
     ))
   ) : null;
 });
+
+PluginHook.displayName = 'PluginHook';

src/components/WindowCanvasNavigationControls.js

@@ -87,3 +87,5 @@ WindowCanvasNavigationControls.defaultProps = {
   showZoomControls: false,
   visible: true,
 };
+
+WindowCanvasNavigationControls.displayName = 'WindowCanvasNavigationControls';

src/lib/CanvasWorld.js

@@ -38,7 +38,7 @@ export default class CanvasWorld {
       let canvasHeight = 0;
       let canvasWidth = 0;
 
-      if (!isNaN(canvas.aspectRatio)) {
+      if (!Number.isNaN(canvas.aspectRatio)) {
         if (dirY === 0) {
           // constant height
           canvasHeight = scale;