Skip to content

Commit f865488

Browse files
committed
test: keep cadence fixture outputs independent and accuracy-valid
1 parent bb757f5 commit f865488

1 file changed

Lines changed: 14 additions & 23 deletions

File tree

‎control_plane/src/physical/compiler.rs‎

Lines changed: 14 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -7065,35 +7065,26 @@ pub(crate) mod tests {
70657065
Query("sum_over_time(n[1m])".into());
70667066
let (mut request, env) = snapshot.into_physical_compilation_request().unwrap();
70677067
let (right, _) = right.into_physical_compilation_request().unwrap();
7068-
let left = request.queries[0].selected_plan_root.clone();
7069-
let right = right.queries[0].selected_plan_root.clone();
7070-
request.queries[0].selected_plan_root = Rc::new(SummaryNode {
7071-
expr: SummaryExpr::BinaryOp {
7072-
timing: planner_types::post_asap::ExecutionTiming::QueryTime,
7073-
lhs: left.clone(),
7074-
rhs: right,
7075-
operator: planner_types::post_asap::BinaryOperator {
7076-
checked_relative_division: false,
7077-
checked_finite_division: false,
7078-
kind: planner_types::pre_asap::BinaryOpKind::Arithmetic(
7079-
planner_types::pre_asap::ArithmeticOpKind::Add,
7080-
),
7081-
vector_match: None,
7082-
},
7083-
},
7084-
schema: left.schema.clone(),
7085-
guarantee: None,
7086-
});
7087-
let text = "quantile(0.9, sum_over_time(m[1m])) + sum_over_time(n[1m])";
7088-
request.queries[0].query_string = text.into();
7068+
// These are independent query outputs. Adding an approximate quantile
7069+
// to an exact sum would require a separate composed accuracy proof.
7070+
let mut raw_query = right.queries[0].clone();
7071+
raw_query.query_id = "raw-query".into();
7072+
request.queries.push(raw_query);
70897073
request
70907074
.query_workload
70917075
.as_mut()
70927076
.unwrap()
70937077
.repeating_queries
70947078
.as_mut()
7095-
.unwrap()[0]
7096-
.query = Query(text.into());
7079+
.unwrap()
7080+
.push(
7081+
right
7082+
.query_workload
7083+
.unwrap()
7084+
.repeating_queries
7085+
.unwrap()
7086+
.remove(0),
7087+
);
70977088
prepare_window_implementations(&mut request.queries[0], &model, env.target, 0).unwrap();
70987089
request.queries[0]
70997090
.window_realization_candidates

0 commit comments

Comments
 (0)