Skip to content

Commit df23db9

Browse files
zzylolclaude
andcommitted
docs: correct the provenance of the recorded binding defects
An earlier revision claimed every recorded defect was a regression introduced inside the #737 -> #728 stack, on the grounds that main is green on these paths. Diffing residual_nodes against main does not support that: the function is substantively identical there, and the stack changed only how the accuracy target is derived and the wording of the error message. main is green because its tests never plan these queries, not because the code is correct. That is the more worrying reading, so it should be the recorded one. The fragment mismatch is fixed on main by #781: a context-derived leaf schema was compared for equality against an isolated re-parse that cannot reproduce it, and open schemas are now compared by containment. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent a1f8c39 commit df23db9

2 files changed

Lines changed: 15 additions & 5 deletions

File tree

‎control_plane/tests/issue754_level1.rs‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,16 @@ fn required_summary_shapes(name: &str, fixture: Fixture) -> Vec<(&'static str, R
103103
/// Binding defects this fixture reaches today. Level 1 records them rather than
104104
/// tolerating them silently: each entry must still occur exactly `count` times,
105105
/// so a new instance fails the test and a fixed one forces its line to be
106-
/// deleted. `main` is green on these paths, so every entry is a regression
107-
/// introduced inside the #737 → #728 stack, and all of them must be gone before
108-
/// #775 installs and executes these candidates.
106+
/// deleted. All of them must be gone before #775 installs and executes these
107+
/// candidates.
108+
///
109+
/// These are *not* regressions introduced by this stack, which is what an
110+
/// earlier revision of this comment claimed on the grounds that `main` is
111+
/// green. `residual_nodes` is substantively identical on `main`; the stack
112+
/// changed only how it derives the accuracy target and the wording of this
113+
/// message. `main` is green because its tests never plan these queries, not
114+
/// because the code is correct. The fragment mismatch is fixed on `main` by
115+
/// #781, which compares context-derived leaf schemas by containment.
109116
const KNOWN_BINDING_DEFECTS: &[(&str, &str, usize)] = &[
110117
(
111118
"grouped-rate",

‎docs/evaluation/issue754-human-review/README.md‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,11 @@ recorded as a policy reason rather than a defect.
8989

9090
**Binding defects** are bugs. Three candidates fail with `Planner logical
9191
fragment does not match any original query subtree` and one with a schema
92-
incompatibility. `main` is green on these paths, so each is a regression
93-
introduced inside the #737 → #728 stack. They are enumerated in
92+
incompatibility. They are older than this stack: `residual_nodes` is
93+
substantively identical on `main`, which is green only because its tests never
94+
plan these queries. The fragment mismatch is a context-derived leaf schema
95+
compared for equality against an isolated re-parse that cannot reproduce it;
96+
#781 fixes it on `main` by comparing those schemas by containment. They are enumerated in
9497
`KNOWN_BINDING_DEFECTS` in the Level-1 test with exact occurrence counts: a new
9598
instance fails the test, and a fixed one forces its entry to be deleted. Every
9699
entry must be gone before #775 installs and executes these candidates. The same

0 commit comments

Comments
 (0)