Skip to content

Commit 452ed7d

Browse files
zzylolclaude
andcommitted
refactor(planner): extract the Stage 3 plan-selection crate
Move asap-aware-mapping's Stage 3 modules into the new asap-plan-selection crate: the cost model and its inputs under cost/, plan_selection/mod.rs as the crate root (select_plan, PlanningModels) and candidate_selection, with their tests and the test_support copy. Delete pane_sharing, erp and empirical_comparison, which have no callers (#572), and the snapshot_prepare_cpu helper only empirical_comparison used. A manifest guard rejects the facade and executor. Imports are rewritten without compatibility re-exports (#572, B4). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent a3c2d63 commit 452ed7d

62 files changed

Lines changed: 340 additions & 2208 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎Cargo.lock‎

Lines changed: 19 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Cargo.toml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ members = [
77
"crates/asap-aware-mapping",
88
"crates/logical-optimizer",
99
"crates/physical-optimizer",
10+
"crates/plan-selection",
1011
"crates/frontend-promql",
1112
"crates/frontend-metricsql",
1213
"crates/metricsql-common-parser-support",

‎crates/asap-aware-mapping/Cargo.toml‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,12 @@ name = "asap-aware-mapping"
33
version = "0.1.0"
44
edition = "2021"
55

6-
# #509 Stage 3 and the planner facade over the Stage 1 candidates of
7-
# asap-logical-optimizer and the Stage 2 candidates of asap-physical-optimizer.
6+
# The planner facade (pass/) over the #509 stage crates: Stage 1
7+
# asap-logical-optimizer and Stage 3 asap-plan-selection (which brings Stage 2).
88
# Never depends on a front end.
99
[dependencies]
1010
asap-types = { path = "../types" }
1111
asap-logical-optimizer = { path = "../logical-optimizer" }
12-
asap-physical-optimizer = { path = "../physical-optimizer" }
12+
asap-plan-selection = { path = "../plan-selection" }
1313
thiserror = "2"
14-
serde = { version = "1", features = ["derive"] }
15-
serde_json = "1"
1614

17-
[dev-dependencies]
18-
asap-frontend-promql = { path = "../frontend-promql" }

0 commit comments

Comments
 (0)