Commit d22f63c
committed
Merge dashpay#7450: test: make governance vote fixtures wire-valid
e058152 test: make governance vote fixtures wire-valid (PastaClaw)
Pull request description:
## Issue being fixed or feature implemented
The governance inventory tests merged in dashpay#7442 construct unsigned synthetic votes and round-trip them through the network parser. Develop now requires governance vote signatures to use a structurally valid 65- or 96-byte encoding, so the fixture is rejected as malformed before the authorization behavior under test is reached. This causes six unit-test failures across CI configurations.
## What was done?
Give the synthetic `VOTE_SIGNAL_FUNDING` vote a compact-signature-sized placeholder. The 65-byte encoding matches the real ECDSA voting-key form for funding votes. These tests deliberately use a missing parent object, so vote processing takes the orphan path before cryptographic signature verification; production validation is unchanged.
## How Has This Been Tested?
- Built `src/test/test_dash` in an isolated macOS arm64 worktree using the depends toolchain
- `./src/test/test_dash --run_test=governance_inv_tests`
- `./src/test/test_dash --run_test=governance_vote_wire_tests`
- `git diff --check`
- Mandatory independent pre-PR review gate: `ship` with no findings
## Breaking Changes
None. Test-only change.
## Checklist:
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [x] I have added or updated relevant unit/integration/functional/e2e tests
- [ ] I have made corresponding changes to the documentation
- [ ] I have assigned this pull request to a milestone
ACKs for top commit:
PastaPastaPasta:
utACK e058152
Tree-SHA512: 5caca1e34ce563444ded42f669ff599f7658c6d1dbea1d541588211ac542ee45f3dd768e158899cb23150c5d45ec8dbcbf412a1472f73a3cc3e72a5ac37636e0
(cherry picked from commit f343d58)1 parent 45cd127 commit d22f63c
1 file changed
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
| 158 | + | |
158 | 159 | | |
159 | 160 | | |
160 | 161 | | |
| |||
0 commit comments