From 11e8248d10dbab8d298a3a05d662edb387eef9fc Mon Sep 17 00:00:00 2001 From: SexyERIC0723 Date: Fri, 10 Apr 2026 23:32:24 +0100 Subject: [PATCH] fix(tests): use correct env var name for PostgreSQL server The skip guard checks CDM5_POSTGRESQL_SERVER, but the actual connection details use CDMDDLBASE_POSTGRESQL_SERVER. This causes tests to run (not skip) in environments where CDM5_POSTGRESQL_SERVER is set but CDMDDLBASE_POSTGRESQL_SERVER is not, leading to failures. Closes #719 --- tests/testthat/setup.R | 2 +- tests/testthat/test-executeDdl.R | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/testthat/setup.R b/tests/testthat/setup.R index 90195ac6..4c541075 100644 --- a/tests/testthat/setup.R +++ b/tests/testthat/setup.R @@ -1,6 +1,6 @@ testDatabases <- c("postgresql") -if (Sys.getenv("CDM5_POSTGRESQL_SERVER") != "") { +if (Sys.getenv("CDMDDLBASE_POSTGRESQL_SERVER") != "") { library(DatabaseConnector) if (dir.exists(Sys.getenv("DATABASECONNECTOR_JAR_FOLDER"))) { diff --git a/tests/testthat/test-executeDdl.R b/tests/testthat/test-executeDdl.R index 15296eaf..0e0aa831 100644 --- a/tests/testthat/test-executeDdl.R +++ b/tests/testthat/test-executeDdl.R @@ -1,7 +1,7 @@ # connection based tests required environment variables be configured test_that("CommonDataModel Execution Test", { - if (Sys.getenv("CDM5_POSTGRESQL_SERVER") != "") { + if (Sys.getenv("CDMDDLBASE_POSTGRESQL_SERVER") != "") { test_that("getConnectionDetails works", { for (dbms in testDatabases) { expect_s3_class(getConnectionDetails(dbms), "ConnectionDetails")