From d8e3a91477e764371e2f98fe93c4813903cb2753 Mon Sep 17 00:00:00 2001
From: "r.perez" <r.perez@binhex.cloud>
Date: Wed, 13 May 2026 15:08:34 -0400
Subject: [PATCH] [IMP] sale_commision_agent_restrict: change res_partner form
 view restriction to _get_view

---
 .../models/res_partner.py                     | 13 +++++++
 .../views/res_partner_views.xml               | 34 -------------------
 2 files changed, 13 insertions(+), 34 deletions(-)

diff --git a/sale_commission_agent_restrict/models/res_partner.py b/sale_commission_agent_restrict/models/res_partner.py
index f37517e1d..47d0c8d8c 100644
--- a/sale_commission_agent_restrict/models/res_partner.py
+++ b/sale_commission_agent_restrict/models/res_partner.py
@@ -96,3 +96,16 @@ def _update_fields_values(self, fields):
                         res.pop("agent_ids")
                         return res
         return res
+
+    @api.model
+    def _get_view(self, view_id=None, view_type="form", **options):
+        arch, view = super()._get_view(view_id=view_id, view_type=view_type, **options)
+
+        if view_type == "form" and self.env.user.has_group(
+            "sale_commission_agent_restrict.group_agent_own_commissions"
+        ):
+            node_page_sale_purchases = arch.xpath("//page[@name='sales_purchases']")[0]
+            node_page_sale_purchases.set("invisible", "1")
+            node_page_internal_notes = arch.xpath("//page[@name='internal_notes']")[0]
+            node_page_internal_notes.set("invisible", "1")
+        return arch, view
diff --git a/sale_commission_agent_restrict/views/res_partner_views.xml b/sale_commission_agent_restrict/views/res_partner_views.xml
index 6c4264396..1368688b1 100644
--- a/sale_commission_agent_restrict/views/res_partner_views.xml
+++ b/sale_commission_agent_restrict/views/res_partner_views.xml
@@ -16,38 +16,4 @@
         </field>
     </record>
 
-    <record id="view_partner_form" model="ir.ui.view">
-        <field name="name">res.partner.form.agent.inherit</field>
-        <field name="model">res.partner</field>
-        <field name="inherit_id" ref="base.view_partner_form" />
-        <field name="arch" type="xml">
-            <!-- Hide these notebook pages from agents -->
-            <page name='sales_purchases' position="attributes">
-                <attribute
-                    name="groups"
-                >!sale_commission_agent_restrict.group_agent_own_commissions</attribute>
-            </page>
-            <page name='internal_notes' position="attributes">
-                <attribute
-                    name="groups"
-                >!sale_commission_agent_restrict.group_agent_own_commissions</attribute>
-            </page>
-            <!-- Add fields needed by context/domains as hidden -->
-            <page name='sales_purchases' position="before">
-                <field
-                    name="user_id"
-                    groups="sale_commission_agent_restrict.group_agent_own_commissions"
-                    invisible="True"
-                />
-                <field
-                    name="team_id"
-                    groups="sale_commission_agent_restrict.group_agent_own_commissions"
-                    invisible="True"
-                />
-            </page>
-        </field>
-    </record>
-
-
-
 </odoo>