Size of repository

[Vito0912]

I already noticed that large files are added for the example application. I understand the size is this big because some epubs contain audio, but the new pull request #136 shows even more binary data being added.

While I see this data is needed for tests, I would appreciate it if e.g. git LFS could be used, so the extra data can easily be avoided.

This ofc would not affect the past history afaik, but it would help keeping the size low.

I just wanted to share this concern, as a size of over 100MB seems a bit high right now. This is not really a feature request and more a idea. If it does not work for you, totally fine

This project is great and thank you for your work!

[ddfreiling]

Very fair observation, I will see about applying git LFS for our test fixture files. I think the size of fixtures also made our Android integration tests flaky now.

We could rework some commit history to get rid of some of the larger books, but that would also make life difficult for open PRs. Will see what I can do.

[Vito0912]

Thanks. I will close this discussion because I have moved on to another library. But I am sure, this still would be great.

This has nothing to do with quality or size. I later found out I can just exclude files of a certain size (although I never tested it with GitHub). However, the main project my client is for moved forward with a different reader library that uses CFIs. Since the Readium toolkit for Android/Kotlin made it clear they will not support CFI, Readium is not a usable option for me.

I still wish you many luck with this package.

[ddfreiling]

Thanks, just curious which other library did you go with and why?

We have not refactored out all test fixtures to a separate repo, so thanks for the heads-up.