Skip to content

Commit 0a041b3

Browse files
authored
Correct directory transaction fault targeting in a versioned test capsule (#168)
## Intent Correct transaction-fault phase targeting in a separate directory acceptance capsule. The original T24/T37/T38 applied mutation outcome faults to earlier guard reads while expecting a held reservation. The new fixture keeps reads committed and injects those faults only for attempted writes; all 44 assertions and original frozen files remain unchanged. ## Risk and compatibility Six new test/documentation files only. No production API, dependency, original registration receipt or frozen-corpus edits. This is a documented mid-implementation harness correction, not retroactive pre-code RED or formal GS. ## Validation evidence - Full local `npm run ci:checks` PASS: 180 suites, 1,400 passed / 42 existing skipped; example e2e 23 + 15 + 51 passed. - Ten phase controls PASS; original fixture fails eight and passes two positive controls. - Explicit missing implementation: 44 controlled failures, no skips or setup errors. - Actual compiled ordinary candidate: 44 PASS, emitted package hashes stable before/after. Candidate final review is separate. - Independent content review READY; exact post-push review and all required GitHub head checks remain required before merge. ## Independent review No GitHub approving review is claimed. The existing clone-local Yehonal review-only merge exception remains unchanged; independent post-push content review will be recorded separately. No provider, runtime rollout, npm publication or host acceptance is included.
1 parent 0b51281 commit 0a041b3

6 files changed

Lines changed: 512 additions & 0 deletions

File tree

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# Directory transaction-phase acceptance correction
2+
3+
This separate test capsule preserves every byte in the original `test/auth/directory-core` freeze and the registration receipt. It corrects fault targeting in DIR-T24/T37/T38: unknown or malformed results intended for a reserved mutation now apply only after that transaction attempted a write. Earlier read transactions must still return committed outcomes. The separate global read-unknown case remains unchanged and requires no reservation.
4+
5+
All 44 original case IDs and assertions are retained. The fixture adds only a trusted test control, not a production API. `phase-controls.test.mjs` discriminates the original fixture from this correction, including failed write attempts, lost COMMIT acknowledgment and committed-after-callback-failure responses. The original fixture has eight failures and two positive controls; the corrected fixture passes all ten controls.
6+
7+
This correction was qualified during ordinary implementation after the original pre-code baseline. It is not retroactive pre-code RED, a replacement source registration, formal generative qualification or real-host admission. An ordinary candidate retaining fail-closed read behavior originally passed 41 of 44 cases; the other three had the independently reproduced phase defect. Those original observations remain valid historical evidence.
8+
9+
```sh
10+
node --test --test-reporter=tap test/auth/directory-core-phase-v1/phase-controls.test.mjs
11+
node --test --test-reporter=tap test/auth/directory-core-phase-v1/conformance.test.mjs
12+
```
13+
14+
The conformance default remains the explicit unimplemented baseline: 44 controlled failures, no skips. Set `YALC_AUTH_DIRECTORY_CANDIDATE` to the actual absolute compiled ESM entry exporting `createIdentityDirectory` to observe a candidate. Set `DIRECTORY_FIXTURE_CANDIDATE` to the absolute original `test/auth/directory-core/fixtures.mjs` to reproduce the eight harness-control failures. The original manifest and receipt remain authoritative for their original inputs; this capsule manifest binds only this separately reviewed harness correction. Provider, session-binding, persistence, funding and lifecycle host gates remain separate.

0 commit comments

Comments
 (0)