Repository navigation
Commit ea7e971
committed
Consult ignore_eos when classifying a finish reason at the output limit
A request with ignore_eos suppresses end-of-sequence termination, so its last
sampled token can be an EOS id while it finishes on the output limit. The
terminal event classified that as a stop with Eos termination, which tells
clients a truncated generation completed normally.
Use the request's ignore_eos setting in the finish-reason classification, the
same way the emitting and logprob paths already do, and document the finish
reason the client sees for each termination cause.
Validation: release Helios library suite on the build host, 1118 passed and 5
failed; the same tree without this change, with the new regression case
applied, is 1117 passed and 6 failed, and the five shared failures are the
pre-existing engram staging and package-cache environment failures reproduced
on the unmodified tree. Both builds also served one prepared single-GPU package
side by side: with greedy sampling, a request that reaches its output limit on
an EOS token reports stop on the unmodified build and length on this one, 6/6
each way, while requests that honour EOS, stop before it, or ignore it without
ending on it report the same reason on both builds. Material limits: the
regression drives the simulated worker phases, and the sampled-EOS suppression
itself is unchanged.
Design-Signed-Off-By: Hermes Agent (DeepSeek V4.1 Flash); design-review=2d931 parent ccf012d commit ea7e971
3 files changed
Lines changed: 11 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | 101 | | |
105 | 102 | | |
106 | 103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
352 | 352 | | |
353 | 353 | | |
354 | 354 | | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
355 | 362 | | |
356 | 363 | | |
357 | 364 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1594 | 1594 | | |
1595 | 1595 | | |
1596 | 1596 | | |
1597 | | - | |
1598 | | - | |
| 1597 | + | |
| 1598 | + | |
1599 | 1599 | | |
1600 | | - | |
1601 | | - | |
1602 | | - | |
1603 | | - | |
1604 | | - | |
1605 | | - | |
| 1600 | + | |
| 1601 | + | |
1606 | 1602 | | |
1607 | 1603 | | |
1608 | 1604 | | |
| |||
0 commit comments