From 99de7ff612cc35ec3722087836eebd05b31e427a Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 6 Feb 2026 13:40:43 +0000 Subject: [PATCH 1/2] Initial plan From 14e4d29083b1448a976a8149a4b6ca3595a81783 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 6 Feb 2026 13:43:34 +0000 Subject: [PATCH 2/2] Rename invalid-utf8-license to .plist and refactor test to actually test it Co-authored-by: MartinP7r <2669027+MartinP7r@users.noreply.github.com> --- Tests/AckGenTests/AcknowledgementAllTests.swift | 17 +++-------------- ...-utf8-license => invalid-utf8-license.plist} | 0 2 files changed, 3 insertions(+), 14 deletions(-) rename Tests/AckGenTests/Fixtures/{invalid-utf8-license => invalid-utf8-license.plist} (100%) diff --git a/Tests/AckGenTests/AcknowledgementAllTests.swift b/Tests/AckGenTests/AcknowledgementAllTests.swift index 0750ad2..3b5da7e 100644 --- a/Tests/AckGenTests/AcknowledgementAllTests.swift +++ b/Tests/AckGenTests/AcknowledgementAllTests.swift @@ -58,23 +58,12 @@ final class AcknowledgementAllTests: XCTestCase { } func testAllReturnsEmptyArrayForInvalidPlist() { - // Given: An invalid file (the invalid-utf8-license fixture) + // Given: An invalid plist file (the invalid-utf8-license fixture) // Note: This test verifies graceful handling of invalid data // The all() method should return empty array for any decode failure - let bundle = Bundle.module - - // When: Loading from a plist that would fail to decode - // (Using Fixtures subdirectory path) - guard let path = bundle.path(forResource: "invalid-utf8-license", ofType: nil, inDirectory: "Fixtures") else { - XCTFail("Could not find invalid-utf8-license fixture") - return - } - // Verify the file exists and contains invalid data - XCTAssertNotNil(FileManager.default.contents(atPath: path)) - - // When: Attempting to decode as plist, it should fail gracefully - let acks = Acknowledgement.all(fromPlist: "NonExistent", in: bundle) + // When: Attempting to decode a plist with invalid UTF-8 content + let acks = loadAcknowledgementsFromFixture(plistName: "invalid-utf8-license") // Then: Should return empty array instead of crashing XCTAssertTrue(acks.isEmpty) diff --git a/Tests/AckGenTests/Fixtures/invalid-utf8-license b/Tests/AckGenTests/Fixtures/invalid-utf8-license.plist similarity index 100% rename from Tests/AckGenTests/Fixtures/invalid-utf8-license rename to Tests/AckGenTests/Fixtures/invalid-utf8-license.plist